Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1275853008: Reverts VM thread cleanup (Closed)

Created:
5 years, 4 months ago by zra
Modified:
5 years, 4 months ago
Reviewers:
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -608 lines) Patch
M runtime/bin/dartutils.h View 1 chunk +5 lines, -5 lines 0 comments Download
M runtime/bin/dartutils.cc View 10 chunks +47 lines, -61 lines 0 comments Download
M runtime/bin/dbg_message.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M runtime/bin/gen_snapshot.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M runtime/bin/main.cc View 7 chunks +12 lines, -33 lines 0 comments Download
M runtime/bin/process.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M runtime/bin/run_vm_tests.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/bin/utils.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/vmservice/vmservice_io.dart View 1 chunk +0 lines, -9 lines 0 comments Download
M runtime/include/dart_api.h View 3 chunks +5 lines, -6 lines 0 comments Download
D runtime/tests/vm/dart/spawn_infinite_loop_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D runtime/tests/vm/dart/spawn_shutdown_test.dart View 1 chunk +0 lines, -32 lines 0 comments Download
M runtime/tests/vm/vm.status View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/cpuinfo_test.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/custom_isolate_test.cc View 4 chunks +0 lines, -4 lines 0 comments Download
M runtime/vm/dart.cc View 4 chunks +14 lines, -12 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 3 chunks +8 lines, -10 lines 0 comments Download
M runtime/vm/debugger_api_impl_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/isolate.h View 3 chunks +2 lines, -11 lines 0 comments Download
M runtime/vm/isolate.cc View 13 chunks +49 lines, -148 lines 0 comments Download
M runtime/vm/message_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/service_isolate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/service_isolate.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M runtime/vm/thread.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M runtime/vm/thread_pool.h View 7 chunks +8 lines, -19 lines 0 comments Download
M runtime/vm/thread_pool.cc View 10 chunks +32 lines, -115 lines 0 comments Download
M runtime/vm/thread_pool_test.cc View 4 chunks +29 lines, -49 lines 0 comments Download
M runtime/vm/verified_memory_test.cc View 6 chunks +0 lines, -13 lines 0 comments Download
M tests/isolate/nested_spawn2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/nested_spawn_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
zra
5 years, 4 months ago (2015-08-08 02:10:36 UTC) #1
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
d4d89d6f12b44514336f1af748e466607bcd1453 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698