Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: runtime/include/dart_api.h

Issue 1275853008: Reverts VM thread cleanup (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/vmservice/vmservice_io.dart ('k') | runtime/tests/vm/dart/spawn_infinite_loop_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/include/dart_api.h
diff --git a/runtime/include/dart_api.h b/runtime/include/dart_api.h
index 41b1cb18f40e4d39211079f37e1a2e3aba4cfa33..d3f54b1b48ede03ca59aad692b1cbabd5994f12d 100755
--- a/runtime/include/dart_api.h
+++ b/runtime/include/dart_api.h
@@ -368,6 +368,7 @@ DART_EXPORT void _Dart_ReportErrorHandle(const char* file,
} \
} \
+
/**
* Converts an object to a string.
*
@@ -860,10 +861,9 @@ typedef bool (*Dart_EntropySource)(uint8_t* buffer, intptr_t length);
* \param shutdown A function to be called when an isolate is shutdown.
* See Dart_IsolateShutdownCallback.
*
- * \return NULL if initialization is successful. Returns an error message
- * otherwise. The caller is responsible for freeing the error message.
+ * \return True if initialization is successful.
*/
-DART_EXPORT char* Dart_Initialize(
+DART_EXPORT bool Dart_Initialize(
const uint8_t* vm_isolate_snapshot,
Dart_IsolateCreateCallback create,
Dart_IsolateInterruptCallback interrupt,
@@ -878,10 +878,9 @@ DART_EXPORT char* Dart_Initialize(
/**
* Cleanup state in the VM before process termination.
*
- * \return NULL if cleanup is successful. Returns an error message otherwise.
- * The caller is responsible for freeing the error message.
+ * \return True if cleanup is successful.
*/
-DART_EXPORT char* Dart_Cleanup();
+DART_EXPORT bool Dart_Cleanup();
/**
* Sets command line flags. Should be called before Dart_Initialize.
« no previous file with comments | « runtime/bin/vmservice/vmservice_io.dart ('k') | runtime/tests/vm/dart/spawn_infinite_loop_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698