Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: runtime/bin/vmservice/vmservice_io.dart

Issue 1275853008: Reverts VM thread cleanup (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/utils.h ('k') | runtime/include/dart_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/vmservice/vmservice_io.dart
diff --git a/runtime/bin/vmservice/vmservice_io.dart b/runtime/bin/vmservice/vmservice_io.dart
index d9b0c754f1735b403314209d7a5968e382249799..409bc5972a0c110d842c0da006e319a958bef8ff 100644
--- a/runtime/bin/vmservice/vmservice_io.dart
+++ b/runtime/bin/vmservice/vmservice_io.dart
@@ -89,15 +89,6 @@ main() {
// scheduled microtasks.
Timer.run(() {});
}
- // TODO(johnmccutchan, turnidge) Creating a VMService object here causes
- // strange behavior from the legacy debug protocol and coverage tool.
- // Enable this code, and remove the call to Isolate::KillIsolate() from
- // service_isolate.cc when the strange behavior is solved.
- // See: https://github.com/dart-lang/sdk/issues/23977
- // else {
- // var service = new VMService();
- // service.onShutdown = _onShutdown;
- // }
scriptLoadPort.handler = _processLoadRequest;
// Register signal handler after a small delay to avoid stalling main
// isolate startup.
« no previous file with comments | « runtime/bin/utils.h ('k') | runtime/include/dart_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698