Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1270803003: VM: More abstract interface for generating stub calls. (Closed)

Created:
5 years, 4 months ago by Florian Schneider
Modified:
5 years, 4 months ago
Reviewers:
rmacnak, srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: More abstract interface for generating stub calls. This makes the code in the code generator independent from how stubs are actually called (i.e. directly embedding the target address, or indirectly by loading the target address from the code object). BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/63a8e5227d40473d13d906cdcf7ee121ee144267

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+502 lines, -361 lines) Patch
M runtime/vm/assembler_arm.h View 2 chunks +6 lines, -0 lines 0 comments Download
M runtime/vm/assembler_arm.cc View 1 4 chunks +32 lines, -1 line 0 comments Download
M runtime/vm/assembler_arm64.h View 4 chunks +9 lines, -0 lines 0 comments Download
M runtime/vm/assembler_arm64.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M runtime/vm/assembler_ia32.h View 2 chunks +6 lines, -0 lines 0 comments Download
M runtime/vm/assembler_ia32.cc View 3 chunks +20 lines, -2 lines 0 comments Download
M runtime/vm/assembler_mips.h View 4 chunks +11 lines, -0 lines 0 comments Download
M runtime/vm/assembler_mips.cc View 1 chunk +31 lines, -0 lines 0 comments Download
M runtime/vm/assembler_x64.h View 3 chunks +7 lines, -0 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 1 6 chunks +38 lines, -1 line 0 comments Download
M runtime/vm/code_patcher_arm64_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/code_patcher_arm_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/code_patcher_ia32_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/code_patcher_mips_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/code_patcher_x64_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/dart_entry.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/debugger_arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/debugger_arm64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/debugger_ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/debugger_mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/debugger_x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/exceptions.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_compiler.h View 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 3 chunks +14 lines, -13 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 17 chunks +28 lines, -29 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm64.cc View 17 chunks +28 lines, -29 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 17 chunks +28 lines, -29 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 17 chunks +28 lines, -29 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 17 chunks +28 lines, -29 lines 0 comments Download
M runtime/vm/instructions_arm64_test.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M runtime/vm/instructions_arm_test.cc View 7 chunks +10 lines, -12 lines 0 comments Download
M runtime/vm/instructions_ia32_test.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M runtime/vm/instructions_mips_test.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M runtime/vm/instructions_x64_test.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 4 chunks +12 lines, -13 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 10 chunks +13 lines, -16 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 10 chunks +13 lines, -16 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 8 chunks +15 lines, -16 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 9 chunks +13 lines, -16 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 8 chunks +11 lines, -15 lines 0 comments Download
M runtime/vm/isolate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/native_arguments.h View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/runtime_entry_arm.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/runtime_entry_arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/runtime_entry_ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/runtime_entry_mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/runtime_entry_x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/stub_code.h View 2 chunks +2 lines, -8 lines 0 comments Download
M runtime/vm/stub_code.cc View 3 chunks +10 lines, -8 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/vm/thread.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Florian Schneider
This is a fairly mechanical refactoring. The generated code is still the same with this ...
5 years, 4 months ago (2015-08-04 12:04:31 UTC) #2
rmacnak
LGTM
5 years, 4 months ago (2015-08-05 01:04:18 UTC) #3
Florian Schneider
Committed patchset #2 (id:20001) manually as 63a8e5227d40473d13d906cdcf7ee121ee144267 (presubmit successful).
5 years, 4 months ago (2015-08-05 08:18:39 UTC) #4
srdjan
5 years, 4 months ago (2015-08-05 18:25:34 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698