Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: runtime/vm/instructions_arm64_test.cc

Issue 1270803003: VM: More abstract interface for generating stub calls. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | runtime/vm/instructions_arm_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/instructions_arm64_test.cc
diff --git a/runtime/vm/instructions_arm64_test.cc b/runtime/vm/instructions_arm64_test.cc
index c44b40bc9196df7d4b7320404121beba1e85a12c..924d495c7c46ccb1fa55fb5e641245814cea9806 100644
--- a/runtime/vm/instructions_arm64_test.cc
+++ b/runtime/vm/instructions_arm64_test.cc
@@ -18,7 +18,7 @@ namespace dart {
ASSEMBLER_TEST_GENERATE(Call, assembler) {
// Code accessing pp is generated, but not executed. Uninitialized pp is OK.
__ set_constant_pool_allowed(true);
- __ BranchLinkPatchable(&StubCode::InvokeDartCodeLabel());
+ __ BranchLinkPatchable(*StubCode::InvokeDartCode_entry());
__ ret();
}
@@ -29,15 +29,14 @@ ASSEMBLER_TEST_RUN(Call, test) {
// before the end of the code buffer.
CallPattern call(test->entry() + test->code().Size() - Instr::kInstrSize,
test->code());
- EXPECT_EQ(StubCode::InvokeDartCodeLabel().address(),
+ EXPECT_EQ(StubCode::InvokeDartCode_entry()->label().address(),
call.TargetAddress());
}
ASSEMBLER_TEST_GENERATE(Jump, assembler) {
- __ BranchPatchable(&StubCode::InvokeDartCodeLabel());
- const ExternalLabel array_label(StubCode::AllocateArrayEntryPoint());
- __ BranchPatchable(&array_label);
+ __ BranchPatchable(*StubCode::InvokeDartCode_entry());
+ __ BranchPatchable(*StubCode::AllocateArray_entry());
}
@@ -50,7 +49,7 @@ ASSEMBLER_TEST_RUN(Jump, test) {
VirtualMemory::kReadWrite);
EXPECT(status);
JumpPattern jump1(test->entry(), test->code());
- EXPECT_EQ(StubCode::InvokeDartCodeLabel().address(),
+ EXPECT_EQ(StubCode::InvokeDartCode_entry()->label().address(),
jump1.TargetAddress());
JumpPattern jump2(test->entry() + jump1.pattern_length_in_bytes(),
test->code());
@@ -62,7 +61,7 @@ ASSEMBLER_TEST_RUN(Jump, test) {
jump1.SetTargetAddress(target2);
jump2.SetTargetAddress(target1);
EXPECT_EQ(array_stub.EntryPoint(), jump1.TargetAddress());
- EXPECT_EQ(StubCode::InvokeDartCodeLabel().address(),
+ EXPECT_EQ(StubCode::InvokeDartCode_entry()->label().address(),
jump2.TargetAddress());
}
« no previous file with comments | « runtime/vm/flow_graph_compiler_x64.cc ('k') | runtime/vm/instructions_arm_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698