Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Unified Diff: runtime/vm/instructions_x64_test.cc

Issue 1270803003: VM: More abstract interface for generating stub calls. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/instructions_mips_test.cc ('k') | runtime/vm/intermediate_language.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/instructions_x64_test.cc
diff --git a/runtime/vm/instructions_x64_test.cc b/runtime/vm/instructions_x64_test.cc
index f6c7df82f545b890b7ef90d70b3f203c2b6718e8..0ad829486502baee864a79a04058bf6cc7d56ac6 100644
--- a/runtime/vm/instructions_x64_test.cc
+++ b/runtime/vm/instructions_x64_test.cc
@@ -15,7 +15,7 @@ namespace dart {
#define __ assembler->
ASSEMBLER_TEST_GENERATE(Call, assembler) {
- __ call(&StubCode::InvokeDartCodeLabel());
+ __ Call(*StubCode::InvokeDartCode_entry());
__ ret();
}
@@ -28,9 +28,8 @@ ASSEMBLER_TEST_GENERATE(Jump, assembler) {
__ pushq(PP);
__ LoadPoolPointer();
prologue_code_size = assembler->CodeSize();
- __ JmpPatchable(&StubCode::InvokeDartCodeLabel(), PP);
- const ExternalLabel array_label(StubCode::AllocateArrayEntryPoint());
- __ JmpPatchable(&array_label, PP);
+ __ JmpPatchable(*StubCode::InvokeDartCode_entry(), PP);
+ __ JmpPatchable(*StubCode::AllocateArray_entry(), PP);
__ popq(PP);
__ ret();
}
@@ -47,7 +46,7 @@ ASSEMBLER_TEST_RUN(Jump, test) {
EXPECT(status);
JumpPattern jump1(test->entry() + prologue_code_size, test->code());
jump1.IsValid();
- EXPECT_EQ(StubCode::InvokeDartCodeLabel().address(),
+ EXPECT_EQ(StubCode::InvokeDartCode_entry()->label().address(),
jump1.TargetAddress());
JumpPattern jump2((test->entry() +
jump1.pattern_length_in_bytes() + prologue_code_size),
@@ -60,7 +59,7 @@ ASSEMBLER_TEST_RUN(Jump, test) {
jump1.SetTargetAddress(target2);
jump2.SetTargetAddress(target1);
EXPECT_EQ(array_stub.EntryPoint(), jump1.TargetAddress());
- EXPECT_EQ(StubCode::InvokeDartCodeLabel().address(),
+ EXPECT_EQ(StubCode::InvokeDartCode_entry()->label().address(),
jump2.TargetAddress());
}
« no previous file with comments | « runtime/vm/instructions_mips_test.cc ('k') | runtime/vm/intermediate_language.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698