Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1269223004: Expose PhantomJS's remote debugger URL. (Closed)

Created:
5 years, 4 months ago by nweiz
Modified:
5 years, 4 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Expose PhantomJS's remote debugger URL. Closes #296 Closes #297 R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/7f7e5b4fd42be47179dfbb830b83f27105c3cd5d

Patch Set 1 #

Patch Set 2 : Fix a test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -65 lines) Patch
M lib/src/runner.dart View 5 chunks +6 lines, -22 lines 0 comments Download
M lib/src/runner/browser/browser_manager.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/src/runner/browser/phantom_js.dart View 1 chunk +48 lines, -32 lines 0 comments Download
M lib/src/util/io.dart View 1 chunk +13 lines, -5 lines 0 comments Download
M test/runner/pause_after_load_test.dart View 1 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 4 months ago (2015-08-04 23:22:26 UTC) #1
kevmoo
lgtm
5 years, 4 months ago (2015-08-04 23:31:07 UTC) #2
nweiz
5 years, 4 months ago (2015-08-05 00:18:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7f7e5b4fd42be47179dfbb830b83f27105c3cd5d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698