Expose PhantomJS's remote debugger URL.

lib/src/runner.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.runner;
 
 import 'dart:async';
 import 'dart:io';
 
 import 'package:async/async.dart';
 
 import 'backend/test_platform.dart';
 import 'runner/application_exception.dart';
 import 'runner/configuration.dart';
 import 'runner/engine.dart';
 import 'runner/load_exception.dart';
 import 'runner/load_suite.dart';
 import 'runner/loader.dart';
 import 'runner/reporter.dart';
 import 'runner/reporter/compact.dart';
 import 'runner/reporter/expanded.dart';
 import 'runner/runner_suite.dart';
 import 'util/io.dart';
 import 'utils.dart';
 
-/// The set of platforms for which debug flags are (currently) not supported.
-final _debugUnsupportedPlatforms = new Set.from(
-    [TestPlatform.vm, TestPlatform.phantomJS]);
-
 /// A class that loads and runs tests based on a [Configuration].
 ///
 /// This maintains a [Loader] and an [Engine] and passes test suites from one to
 /// the other, as well as printing out tests with a [CompactReporter] or an
 /// [ExpandedReporter].
 class Runner {
   /// The configuration for the runner.
   final Configuration _config;
 
   /// The loader that loads the test suites from the filesystem.
@@ skipping 125 matching lines @@
         if (_config.pattern == null) return suite;
         return suite.change(tests: suite.tests.where((test) =>
             test.name.contains(_config.pattern)));
       });
     });
   }
 
   /// Loads each suite in [suites] in order, pausing after load for platforms
   /// that support debugging.
   Future<bool> _loadThenPause(Stream<LoadSuite> suites) async {
-    var unsupportedPlatforms = _config.platforms
-        .where(_debugUnsupportedPlatforms.contains)
-        .map((platform) =>
-             platform == TestPlatform.vm ? "the Dart VM" : platform.name)
-        .toList();
-
-    if (unsupportedPlatforms.isNotEmpty) {
-      warn(
-          wordWrap("Debugging is currently unsupported on "
-              "${toSentence(unsupportedPlatforms)}."),
+    if (_config.platforms.contains(TestPlatform.vm)) {
+      warn("Debugging is currently unsupported on the Dart VM.",
           color: _config.color);
     }
 
     _suiteSubscription = suites.asyncMap((loadSuite) async {
       // Make the underlying suite null so that the engine doesn't start running
       // it immediately.
       _engine.suiteSink.add(loadSuite.changeSuite((_) => null));
 
       var suite = await loadSuite.suite;
       if (suite == null) return;
@@ skipping 12 matching lines @@
     return results.last;
   }
 
   /// Pauses the engine and the reporter so that the user can set breakpoints as
   /// necessary.
   ///
   /// This is a no-op for test suites that aren't on platforms where debugging
   /// is supported.
   Future _pause(RunnerSuite suite) async {
     if (suite.platform == null) return;
-    if (_debugUnsupportedPlatforms.contains(suite.platform)) return;
+    if (suite.platform == TestPlatform.vm) return;
 
     try {
       _reporter.pause();
 
       var bold = _config.color ? '\u001b[1m' : '';
       var yellow = _config.color ? '\u001b[33m' : '';
       var noColor = _config.color ? '\u001b[0m' : '';
       print('');
 
       if (suite.platform.isDartVM) {
         var url = suite.environment.observatoryUrl;
         if (url == null) {
           print("${yellow}Observatory URL not found. Make sure you're using "
               "${suite.platform.name} 1.11 or later.$noColor");
         } else {
           print("Observatory URL: $bold$url$noColor");
         }
       }
 
-      if (suite.platform == TestPlatform.contentShell) {
+      if (suite.platform.isHeadless) {
         var url = suite.environment.remoteDebuggerUrl;
         if (url == null) {
           print("${yellow}Remote debugger URL not found.$noColor");
         } else {
           print("Remote debugger URL: $bold$url$noColor");
         }
       }
 
       var buffer = new StringBuffer(
           "${bold}The test runner is paused.${noColor} ");
       if (!suite.platform.isHeadless) {
         buffer.write("Open the dev console in ${suite.platform} ");
-        if (suite.platform.isDartVM) buffer.write("or ");
       } else {
-        buffer.write("Open ");
-        if (suite.platform == TestPlatform.contentShell) {
-          buffer.write("the remote debugger or ");
-        }
+        buffer.write("Open the remote debugger ");
       }
-      if (suite.platform.isDartVM) buffer.write("the Observatory ");
+      if (suite.platform.isDartVM) buffer.write("or the Observatory ");
 
       buffer.write("and set breakpoints. Once you're finished, return to this "
           "terminal and press Enter.");
 
       print(wordWrap(buffer.toString()));
 
       await inCompletionOrder([
         suite.environment.displayPause(),
         cancelableNext(stdinLines)
       ]).first;
     } finally {
       _reporter.resume();
     }
   }
 }