Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1012)

Unified Diff: lib/src/runner/browser/browser_manager.dart

Issue 1269223004: Expose PhantomJS's remote debugger URL. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Fix a test. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/runner.dart ('k') | lib/src/runner/browser/phantom_js.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner/browser/browser_manager.dart
diff --git a/lib/src/runner/browser/browser_manager.dart b/lib/src/runner/browser/browser_manager.dart
index 5442d7528d1dfa66af34b93fa60740bf3fac812f..88bcbcb771ceafa989a52d57fc87a0527339c24e 100644
--- a/lib/src/runner/browser/browser_manager.dart
+++ b/lib/src/runner/browser/browser_manager.dart
@@ -128,7 +128,7 @@ class BrowserManager {
case TestPlatform.contentShell:
return new ContentShell(url, debug: debug);
case TestPlatform.chrome: return new Chrome(url);
- case TestPlatform.phantomJS: return new PhantomJS(url);
+ case TestPlatform.phantomJS: return new PhantomJS(url, debug: debug);
case TestPlatform.firefox: return new Firefox(url);
case TestPlatform.safari: return new Safari(url);
case TestPlatform.internetExplorer: return new InternetExplorer(url);
@@ -153,7 +153,7 @@ class BrowserManager {
if (_platform.isDartVM) observatoryUrl = await _browser.observatoryUrl;
var remoteDebuggerUrl;
- if (_platform == TestPlatform.contentShell) {
+ if (_platform.isHeadless) {
remoteDebuggerUrl = await _browser.remoteDebuggerUrl;
}
« no previous file with comments | « lib/src/runner.dart ('k') | lib/src/runner/browser/phantom_js.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698