Fix up static analysis errors introduced by Futures CL.

Fix up static analysis errors introduced by Futures CL.


BUG=

Committed: https://code.google.com/p/dart/source/detail?r=20120

[blois, 2013-03-15 20:38:43]

lgtm

Looks good, one nit.

https://codereview.chromium.org/12653008/diff/1/tools/dom/templates/html/impl...
File tools/dom/templates/html/impl/impl_StorageInfo.darttemplate (right):

https://codereview.chromium.org/12653008/diff/1/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_StorageInfo.darttemplate:26: int
currentUsageInBytes;
these should be final.

[Andrei Mouravski, 2013-03-15 21:08:16]

Mostly style changes and one documentation change.

https://codereview.chromium.org/12653008/diff/1/tools/dom/templates/html/impl...
File tools/dom/templates/html/impl/impl_RTCPeerConnection.darttemplate (right):

https://codereview.chromium.org/12653008/diff/1/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_RTCPeerConnection.darttemplate:45: (value) {
completer.complete(value); },
=> maybe? Here and below.

https://codereview.chromium.org/12653008/diff/1/tools/dom/templates/html/impl...
File tools/dom/templates/html/impl/impl_StorageInfo.darttemplate (right):

https://codereview.chromium.org/12653008/diff/1/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_StorageInfo.darttemplate:12:
(currentUsageInBytes, currentQuotaInBytes) {
You could use an => here, too.

https://codereview.chromium.org/12653008/diff/1/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_StorageInfo.darttemplate:14:
currentQuotaInBytes));
There should be 2 more spaces before "currentQuotaInBytes"

https://codereview.chromium.org/12653008/diff/1/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_StorageInfo.darttemplate:16: (error) {
completer.completeError(error); });
Just use an =>

https://codereview.chromium.org/12653008/diff/1/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_StorageInfo.darttemplate:22: * A simple
container class for the two values that are returned from the
I'd simplify this to:
"A container class for the usage and quota of a [Storage] service."

*Note: I'm not sure what this is usage and quota of, so everything I wrote after
"of a" should be replaced by what this actually represents.

https://codereview.chromium.org/12653008/diff/1/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_StorageInfo.darttemplate:23: * futures in
requestQuota and queryUsageAndQuota.
You don't need to mention the methods that produce this object, since the
methods themselves will link to this. You should link to their *source.* (See
above.)

https://codereview.chromium.org/12653008/diff/1/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_StorageInfo.darttemplate:28:
StorageInfoUsage(this.currentUsageInBytes, this.currentQuotaInBytes);
Make this a const constructor.

[Emily Fortuna, 2013-03-15 23:03:24]

https://codereview.chromium.org/12653008/diff/1/tools/dom/templates/html/impl...
File tools/dom/templates/html/impl/impl_RTCPeerConnection.darttemplate (right):

https://codereview.chromium.org/12653008/diff/1/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_RTCPeerConnection.darttemplate:45: (value) {
completer.complete(value); },
On 2013/03/15 21:08:16, Andrei Mouravski wrote:
> => maybe? Here and below.

Last I checked the convention was don't use => if you're not actually returning
a value. In this case it's void for the lambda.

https://codereview.chromium.org/12653008/diff/1/tools/dom/templates/html/impl...
File tools/dom/templates/html/impl/impl_StorageInfo.darttemplate (right):

https://codereview.chromium.org/12653008/diff/1/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_StorageInfo.darttemplate:14:
currentQuotaInBytes));
On 2013/03/15 21:08:16, Andrei Mouravski wrote:
> There should be 2 more spaces before "currentQuotaInBytes"

Done.

[Emily Fortuna, 2013-03-15 23:06:18]

Committed patchset #3 manually as r20120 (presubmit successful).

[Andrei Mouravski, 2013-03-15 23:09:33]

Err...

https://codereview.chromium.org/12653008/diff/1/tools/dom/templates/html/impl...
File tools/dom/templates/html/impl/impl_RTCPeerConnection.darttemplate (right):

https://codereview.chromium.org/12653008/diff/1/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_RTCPeerConnection.darttemplate:45: (value) {
completer.complete(value); },
This:
http://www.dartlang.org/articles/idiomatic-dart/#fields-getters-and-setters

suggests the opposite. Note the setters don't return anything and still use =>

https://codereview.chromium.org/12653008/diff/1/tools/dom/templates/html/impl...
File tools/dom/templates/html/impl/impl_StorageInfo.darttemplate (right):

https://codereview.chromium.org/12653008/diff/1/tools/dom/templates/html/impl...
tools/dom/templates/html/impl/impl_StorageInfo.darttemplate:22: * A simple
container class for the two values that are returned from the
No change on this?