Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: tools/dom/templates/html/impl/impl_StorageInfo.darttemplate

Issue 12653008: Fix up static analysis errors introduced by Futures CL. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file.
4
5 part of $LIBRARYNAME;
6
7 $(ANNOTATIONS)class $CLASSNAME$EXTENDS$IMPLEMENTS$NATIVESPEC {
8 $!MEMBERS
9 Future<StorageInfoUsage> queryUsageAndQuota(int storageType) {
10 var completer = new Completer<int>();
11 _queryUsageAndQuota(storageType,
12 (currentUsageInBytes, currentQuotaInBytes) {
Andrei Mouravski 2013/03/15 21:08:16 You could use an => here, too.
13 completer.complete(new StorageInfoUsage(currentUsageInBytes,
14 currentQuotaInBytes));
Andrei Mouravski 2013/03/15 21:08:16 There should be 2 more spaces before "currentQuota
Emily Fortuna 2013/03/15 23:03:24 Done.
15 },
16 (error) { completer.completeError(error); });
Andrei Mouravski 2013/03/15 21:08:16 Just use an =>
17 return completer.future;
18 }
19 }
20
21 /**
22 * A simple container class for the two values that are returned from the
Andrei Mouravski 2013/03/15 21:08:16 I'd simplify this to: "A container class for the u
Andrei Mouravski 2013/03/15 23:09:33 No change on this?
23 * futures in requestQuota and queryUsageAndQuota.
Andrei Mouravski 2013/03/15 21:08:16 You don't need to mention the methods that produce
24 */
25 class StorageInfoUsage {
26 int currentUsageInBytes;
blois 2013/03/15 20:38:44 these should be final.
27 int currentQuotaInBytes;
28 StorageInfoUsage(this.currentUsageInBytes, this.currentQuotaInBytes);
Andrei Mouravski 2013/03/15 21:08:16 Make this a const constructor.
29 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698