Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: sdk/lib/html/dartium/html_dartium.dart

Issue 12653008: Fix up static analysis errors introduced by Futures CL. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | tools/dom/scripts/htmlrenamer.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dartium/html_dartium.dart
diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart
index 4813f54fa03f231306c5f605d5719741f1c09814..5d6a895322352ef8da0d71d1a289ffd27498cfca 100644
--- a/sdk/lib/html/dartium/html_dartium.dart
+++ b/sdk/lib/html/dartium/html_dartium.dart
@@ -21177,6 +21177,21 @@ class RtcPeerConnection extends EventTarget {
* the current platform.
*/
static bool get supported => true;
+ Future<RtcSessionDescription> createOffer([Map mediaConstraints]) {
+ var completer = new Completer<RtcSessionDescription>();
+ _createOffer(
+ (value) { completer.complete(value); },
+ (error) { completer.completeError(error); }, mediaConstraints);
+ return completer.future;
+ }
+
+ Future<RtcSessionDescription> createAnswer([Map mediaConstraints]) {
+ var completer = new Completer<RtcSessionDescription>();
+ _createAnswer(
+ (value) { completer.complete(value); },
+ (error) { completer.completeError(error); }, mediaConstraints);
+ return completer.future;
+ }
RtcPeerConnection.internal() : super.internal();
@DomName('RTCPeerConnection.addstreamEvent')
@@ -21264,14 +21279,6 @@ class RtcPeerConnection extends EventTarget {
@DocsEditable
void _createAnswer(_RtcSessionDescriptionCallback successCallback, [_RtcErrorCallback failureCallback, Map mediaConstraints]) native "RTCPeerConnection_createAnswer_Callback";
- Future<RtcSessionDescription> createAnswer([Map mediaConstraints]) {
- var completer = new Completer<RtcSessionDescription>();
- _createAnswer(mediaConstraints,
- (value) { completer.complete(value); },
- (error) { completer.completeError(error); });
- return completer.future;
- }
-
@DomName('RTCPeerConnection.createDTMFSender')
@DocsEditable
RtcdtmfSender createDtmfSender(MediaStreamTrack track) native "RTCPeerConnection_createDTMFSender_Callback";
@@ -21284,14 +21291,6 @@ class RtcPeerConnection extends EventTarget {
@DocsEditable
void _createOffer(_RtcSessionDescriptionCallback successCallback, [_RtcErrorCallback failureCallback, Map mediaConstraints]) native "RTCPeerConnection_createOffer_Callback";
- Future<RtcSessionDescription> createOffer([Map mediaConstraints]) {
- var completer = new Completer<RtcSessionDescription>();
- _createOffer(mediaConstraints,
- (value) { completer.complete(value); },
- (error) { completer.completeError(error); });
- return completer.future;
- }
-
@DomName('RTCPeerConnection.dispatchEvent')
@DocsEditable
bool dispatchEvent(Event event) native "RTCPeerConnection_dispatchEvent_Callback";
@@ -23155,14 +23154,11 @@ class StorageEvent extends Event {
void $dom_initStorageEvent(String typeArg, bool canBubbleArg, bool cancelableArg, String keyArg, String oldValueArg, String newValueArg, String urlArg, Storage storageAreaArg) native "StorageEvent_initStorageEvent_Callback";
}
-// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
+// Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-// WARNING: Do not edit - generated code.
-
-@DocsEditable
@DomName('StorageInfo')
class StorageInfo extends NativeFieldWrapperClass1 {
StorageInfo.internal();
@@ -23175,14 +23171,6 @@ class StorageInfo extends NativeFieldWrapperClass1 {
@DocsEditable
void _queryUsageAndQuota(int storageType, [_StorageInfoUsageCallback usageCallback, _StorageInfoErrorCallback errorCallback]) native "StorageInfo_queryUsageAndQuota_Callback";
- Future<int> queryUsageAndQuota(int storageType) {
- var completer = new Completer<int>();
- _queryUsageAndQuota(storageType,
- (value) { completer.complete(value); },
- (error) { completer.completeError(error); });
- return completer.future;
- }
-
@DomName('StorageInfo.requestQuota')
@DocsEditable
void _requestQuota(int storageType, int newQuotaInBytes, [StorageInfoQuotaCallback quotaCallback, _StorageInfoErrorCallback errorCallback]) native "StorageInfo_requestQuota_Callback";
@@ -23195,6 +23183,26 @@ class StorageInfo extends NativeFieldWrapperClass1 {
return completer.future;
}
+ Future<StorageInfoUsage> queryUsageAndQuota(int storageType) {
+ var completer = new Completer<StorageInfoUsage>();
+ _queryUsageAndQuota(storageType,
+ (currentUsageInBytes, currentQuotaInBytes) {
+ completer.complete(new StorageInfoUsage(currentUsageInBytes,
+ currentQuotaInBytes));
+ },
+ (error) { completer.completeError(error); });
+ return completer.future;
+ }
+}
+
+/**
+ * A simple container class for the two values that are returned from the
+ * futures in requestQuota and queryUsageAndQuota.
+ */
+class StorageInfoUsage {
+ final int currentUsageInBytes;
+ final int currentQuotaInBytes;
+ const StorageInfoUsage(this.currentUsageInBytes, this.currentQuotaInBytes);
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
@@ -34638,7 +34646,7 @@ class _HttpRequestUtils {
onComplete(HttpRequest request),
bool withCredentials) {
final request = new HttpRequest();
- request.open('GET', url, true);
+ request.open('GET', url, async: true);
request.withCredentials = withCredentials;
« no previous file with comments | « sdk/lib/html/dart2js/html_dart2js.dart ('k') | tools/dom/scripts/htmlrenamer.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698