Issue 1264393004: Pass Configuration to Loader and Server.

Issue 1264393004: Pass Configuration to Loader and Server. (Closed)

Created:
5 years, 4 months ago by nweiz

Modified:
5 years, 4 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Pass Configuration to Loader and Server. This makes it easier to react to user configuration throughout the runner codebase. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/3e60012e919a044da62e26f87f4ac0b465726422

Patch Set 2 : Code review changes #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -162 lines)			Patch
M	lib/src/runner.dart	View		10 chunks	+28 lines, -39 lines	0 comments	Download
M	lib/src/runner/browser/server.dart	View	1	14 chunks	+27 lines, -50 lines	0 comments	Download
M	lib/src/runner/configuration.dart	View		4 chunks	+9 lines, -2 lines	0 comments	Download
M	lib/src/runner/loader.dart	View		7 chunks	+13 lines, -55 lines	0 comments	Download
M	test/runner/browser/loader_test.dart	View		3 chunks	+10 lines, -6 lines	0 comments	Download
M	test/runner/loader_test.dart	View		3 chunks	+4 lines, -10 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kevmoo

LGTM w/ nits https://codereview.chromium.org/1264393004/diff/1/lib/src/runner/browser/server.dart File lib/src/runner/browser/server.dart (right): https://codereview.chromium.org/1264393004/diff/1/lib/src/runner/browser/server.dart#newcode28 lib/src/runner/browser/server.dart:28: import '../application_exception.dart'; now unused! https://codereview.chromium.org/1264393004/diff/1/lib/src/runner/configuration.dart File ...

5 years, 4 months ago (2015-08-04 22:07:44 UTC) #2

nweiz

https://codereview.chromium.org/1264393004/diff/1/lib/src/runner/browser/server.dart File lib/src/runner/browser/server.dart (right): https://codereview.chromium.org/1264393004/diff/1/lib/src/runner/browser/server.dart#newcode28 lib/src/runner/browser/server.dart:28: import '../application_exception.dart'; On 2015/08/04 22:07:44, kevmoo wrote: > now ...

5 years, 4 months ago (2015-08-04 22:20:56 UTC) #4

nweiz

5 years, 4 months ago (2015-08-04 22:21:32 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
3e60012e919a044da62e26f87f4ac0b465726422 (presubmit successful).

Expand Messages | Collapse Messages