Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: test/runner/browser/loader_test.dart

Issue 1264393004: Pass Configuration to Loader and Server. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Code review changes Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/runner/loader.dart ('k') | test/runner/loader_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/runner/browser/loader_test.dart
diff --git a/test/runner/browser/loader_test.dart b/test/runner/browser/loader_test.dart
index b3210fa557755421c835da5c8701bc182d36dbce..6d2a0a6b2475063bcb879f9f76bdb0954242ce61 100644
--- a/test/runner/browser/loader_test.dart
+++ b/test/runner/browser/loader_test.dart
@@ -9,6 +9,7 @@ import 'dart:io';
import 'package:path/path.dart' as p;
import 'package:test/src/backend/state.dart';
import 'package:test/src/backend/test_platform.dart';
+import 'package:test/src/runner/configuration.dart';
import 'package:test/src/runner/loader.dart';
import 'package:test/src/util/io.dart';
import 'package:test/test.dart';
@@ -34,9 +35,10 @@ void main() {
void main() {
setUp(() {
_sandbox = createTempDir();
- _loader = new Loader([TestPlatform.chrome],
- root: _sandbox,
- packageRoot: p.join(packageDir, 'packages'));
+ _loader = new Loader(new Configuration(
+ platforms: [TestPlatform.chrome],
+ packageRoot: p.join(packageDir, 'packages')),
+ root: _sandbox);
/// TODO(nweiz): Use scheduled_test for this once it's compatible with this
/// version of test.
new File(p.join(_sandbox, 'a_test.dart')).writeAsStringSync(_tests);
@@ -123,9 +125,11 @@ Future main() {
});
test("loads a suite both in the browser and the VM", () async {
- var loader = new Loader([TestPlatform.vm, TestPlatform.chrome],
- root: _sandbox,
- packageRoot: p.join(packageDir, 'packages'));
+ var loader = new Loader(
+ new Configuration(
+ platforms: [TestPlatform.vm, TestPlatform.chrome],
+ packageRoot: p.join(packageDir, 'packages')),
+ root: _sandbox);
var path = p.join(_sandbox, 'a_test.dart');
try {
« no previous file with comments | « lib/src/runner/loader.dart ('k') | test/runner/loader_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698