Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: test/runner/loader_test.dart

Issue 1264393004: Pass Configuration to Loader and Server. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Code review changes Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/runner/browser/loader_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/runner/loader_test.dart
diff --git a/test/runner/loader_test.dart b/test/runner/loader_test.dart
index 02e8af9dadad4885d38e089bd03fb7afa08ffb41..01057b2e5732b5f971d1cae6f045275e14d51b93 100644
--- a/test/runner/loader_test.dart
+++ b/test/runner/loader_test.dart
@@ -9,6 +9,7 @@ import 'dart:io';
import 'package:path/path.dart' as p;
import 'package:test/src/backend/state.dart';
import 'package:test/src/backend/test_platform.dart';
+import 'package:test/src/runner/configuration.dart';
import 'package:test/src/runner/loader.dart';
import 'package:test/src/util/io.dart';
import 'package:test/test.dart';
@@ -34,9 +35,9 @@ void main() {
void main() {
setUp(() {
_sandbox = createTempDir();
- _loader = new Loader([TestPlatform.vm],
- root: _sandbox,
- packageRoot: p.join(packageDir, 'packages'));
+ _loader = new Loader(
+ new Configuration(packageRoot: p.join(packageDir, 'packages')),
+ root: _sandbox);
});
tearDown(() {
@@ -86,13 +87,6 @@ void main() {
expectSingleFailure(liveTest);
return liveTest.run().whenComplete(() => liveTest.close());
});
-
- test("throws a nice error if the package root doesn't exist", () {
- expect(() => new Loader([TestPlatform.chrome], root: _sandbox),
- throwsA(isApplicationException(
- "Directory ${p.prettyUri(p.toUri(p.join(_sandbox, 'packages')))} "
- "does not exist.")));
- });
});
group(".loadDir()", () {
« no previous file with comments | « test/runner/browser/loader_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698