Change all File APIs to make the mode and encoding arguments named

Change all File APIs to make the mode and encoding arguments named

R=ager@google.com, ajohnsen@google.com, whesse@google.com, floitsch@google.com

BUG=

Committed: https://code.google.com/p/dart/source/detail?r=20153

[Søren Gjesse, 2013-03-13 15:45:04]

As we already have some functions where mode and encoding arguments are named I
think this should be consistent.

What do you think?

I have only updated the standalone/io tests, but will fix the rest of the repo
if we go ahead with this.

[floitsch, 2013-03-13 15:50:55]

We should definitely be consistent.
LGTM.
I wonder if we need the FileMode class, if we put always put "mode:" in front.
File.open(mode: FileMode.READ) seems redundant.
File.open(mode: File.READ) would be shorter.

[Mads Ager (google), 2013-03-13 16:08:45]

LGTM

We started out doing this when there were two or more arguments but I think it
is better to just be consistent.

https://codereview.chromium.org/12609004/diff/1/tests/standalone/io/file_inva...
File tests/standalone/io/file_invalid_arguments_test.dart (right):

https://codereview.chromium.org/12609004/diff/1/tests/standalone/io/file_inva...
tests/standalone/io/file_invalid_arguments_test.dart:114: file.openSync(node:
FileMode.WRITE);
mode!

[Bill Hesse, 2013-03-15 09:00:02]

LGTM.

[Søren Gjesse, 2013-03-18 12:10:48]

Committed patchset #2 manually as r20153 (presubmit successful).

[Ivan Posva, 2013-03-20 15:43:13]

The fact that you feel that you have to name the only parameter to a function
tells me that something is wrong with this general direction. In particular it
leads to code like this:

s = file.readAsString(encoding: Encoding.ASCII);

How many time do you have to repeat "encoding" on the single line?

You need to reevaluate whether this change is really needed.

Thanks,
-Ivan