sdk/lib/_internal/compiler/implementation/source_file_provider.dart - Issue 12609004: Change all File APIs to make the mode and encoding arguments named

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/source_file_provider.dart

Issue 12609004: Change all File APIs to make the mode and encoding arguments named (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Addressed review comments and changed other use places Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/dart2js.dart ('k') | sdk/lib/_internal/compiler/implementation/ssa/tracer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/source_file_provider.dart

diff --git a/sdk/lib/_internal/compiler/implementation/source_file_provider.dart b/sdk/lib/_internal/compiler/implementation/source_file_provider.dart

index f58d5ca357dc341b4de754848f285dacfa6adb7a..4157fc9e45175efcba141395e9aa0afd88c51f39 100644

--- a/sdk/lib/_internal/compiler/implementation/source_file_provider.dart

+++ b/sdk/lib/_internal/compiler/implementation/source_file_provider.dart

@@ -1,4 +1,4 @@

// BSD-style license that can be found in the LICENSE file.

@@ -17,7 +17,7 @@ import 'filenames.dart';

import 'util/uri_extras.dart';

String readAll(String filename) {

- var file = (new File(filename)).openSync(FileMode.READ);

+ var file = (new File(filename)).openSync();

var length = file.lengthSync();

var buffer = new List<int>(length);

var bytes = file.readListSync(buffer, 0, length);