Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: sdk/lib/io/file.dart

Issue 12609004: Change all File APIs to make the mode and encoding arguments named (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Addressed review comments and changed other use places Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/dartdoc/lib/src/dartdoc/utils.dart ('k') | sdk/lib/io/file_impl.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/io/file.dart
diff --git a/sdk/lib/io/file.dart b/sdk/lib/io/file.dart
index d484cf382d7c684c3f498a42519df645b52ae542..7de3d7d3ce708aca5d4ae0605010ccb24baadc73 100644
--- a/sdk/lib/io/file.dart
+++ b/sdk/lib/io/file.dart
@@ -135,7 +135,7 @@ abstract class File extends FileSystemEntity {
* [FileMode.APPEND]: same as [FileMode.WRITE] except that the file is
* not truncated.
*/
- Future<RandomAccessFile> open([FileMode mode = FileMode.READ]);
+ Future<RandomAccessFile> open({FileMode mode: FileMode.READ});
/**
* Synchronously open the file for random access operations. The
@@ -145,7 +145,7 @@ abstract class File extends FileSystemEntity {
*
* See [open] for information on the [mode] argument.
*/
- RandomAccessFile openSync([FileMode mode = FileMode.READ]);
+ RandomAccessFile openSync({FileMode mode: FileMode.READ});
/**
* Get the canonical full path corresponding to the file path.
@@ -207,13 +207,13 @@ abstract class File extends FileSystemEntity {
* Returns a [:Future<String>:] that completes with the string once
* the file contents has been read.
*/
- Future<String> readAsString([Encoding encoding = Encoding.UTF_8]);
+ Future<String> readAsString({Encoding encoding: Encoding.UTF_8});
/**
* Synchronously read the entire file contents as a string using the
* given [Encoding].
*/
- String readAsStringSync([Encoding encoding = Encoding.UTF_8]);
+ String readAsStringSync({Encoding encoding: Encoding.UTF_8});
/**
* Read the entire file contents as lines of text using the given
@@ -222,13 +222,13 @@ abstract class File extends FileSystemEntity {
* Returns a [:Future<List<String>>:] that completes with the lines
* once the file contents has been read.
*/
- Future<List<String>> readAsLines([Encoding encoding = Encoding.UTF_8]);
+ Future<List<String>> readAsLines({Encoding encoding: Encoding.UTF_8});
/**
* Synchronously read the entire file contents as lines of text
* using the given [Encoding].
*/
- List<String> readAsLinesSync([Encoding encoding = Encoding.UTF_8]);
+ List<String> readAsLinesSync({Encoding encoding: Encoding.UTF_8});
/**
* Write a list of bytes to a file.
@@ -241,7 +241,7 @@ abstract class File extends FileSystemEntity {
* file if it already exists. In order to append the bytes to an existing
* file, pass [FileMode.APPEND] as the optional mode parameter.
*/
- Future<File> writeAsBytes(List<int> bytes, [FileMode mode = FileMode.WRITE]);
+ Future<File> writeAsBytes(List<int> bytes, {FileMode mode: FileMode.WRITE});
/**
* Synchronously write a list of bytes to a file.
@@ -252,7 +252,7 @@ abstract class File extends FileSystemEntity {
* the file if it already exists. In order to append the bytes to an existing
* file, pass [FileMode.APPEND] as the optional mode parameter.
*/
- void writeAsBytesSync(List<int> bytes, [FileMode mode = FileMode.WRITE]);
+ void writeAsBytesSync(List<int> bytes, {FileMode mode: FileMode.WRITE});
/**
* Write a string to a file.
@@ -381,7 +381,7 @@ abstract class RandomAccessFile {
* RandomAccessFile when the write completes.
*/
Future<RandomAccessFile> writeString(String string,
- [Encoding encoding = Encoding.UTF_8]);
+ {Encoding encoding: Encoding.UTF_8});
/**
* Synchronously writes a single string to the file using the given
@@ -389,7 +389,7 @@ abstract class RandomAccessFile {
* written.
*/
int writeStringSync(String string,
- [Encoding encoding = Encoding.UTF_8]);
+ {Encoding encoding: Encoding.UTF_8});
/**
* Gets the current byte position in the file. Returns a
« no previous file with comments | « sdk/lib/_internal/dartdoc/lib/src/dartdoc/utils.dart ('k') | sdk/lib/io/file_impl.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698