Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1259473005: Fix boolean conversion bug in dart2js + update JSRegExp accordingly. (Closed)

Created:
5 years, 4 months ago by Johnni Winther
Modified:
5 years, 4 months ago
Reviewers:
herhut
CC:
reviews_dartlang.org, vm-dev_dartlang.org, floitsch
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix boolean conversion bug in dart2js + update JSRegExp accordingly. BUG= R=herhut@google.com Committed: https://github.com/dart-lang/sdk/commit/783ed933ff26bb5632b641ae01626fd1ffe00bc4

Patch Set 1 #

Patch Set 2 : Remove comment. #

Total comments: 2

Patch Set 3 : Updated cf. comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -8 lines) Patch
M pkg/compiler/lib/src/ssa/builder.dart View 1 1 chunk +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/nodes.dart View 1 2 2 chunks +17 lines, -1 line 0 comments Download
M sdk/lib/_internal/js_runtime/lib/regexp_helper.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/dart2js.status View 1 chunk +0 lines, -2 lines 0 comments Download
A tests/corelib/regexp/default_arguments_test.dart View 1 chunk +35 lines, -0 lines 0 comments Download
A tests/language/bool_condition_check_test.dart View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
5 years, 4 months ago (2015-07-27 09:45:17 UTC) #2
herhut
lgtm https://codereview.chromium.org/1259473005/diff/20001/pkg/compiler/lib/src/ssa/nodes.dart File pkg/compiler/lib/src/ssa/nodes.dart (right): https://codereview.chromium.org/1259473005/diff/20001/pkg/compiler/lib/src/ssa/nodes.dart#newcode2758 pkg/compiler/lib/src/ssa/nodes.dart:2758: // Don't omit a boolean conversion (which doesn't ...
5 years, 4 months ago (2015-07-27 11:54:49 UTC) #3
Johnni Winther
https://codereview.chromium.org/1259473005/diff/20001/pkg/compiler/lib/src/ssa/nodes.dart File pkg/compiler/lib/src/ssa/nodes.dart (right): https://codereview.chromium.org/1259473005/diff/20001/pkg/compiler/lib/src/ssa/nodes.dart#newcode2758 pkg/compiler/lib/src/ssa/nodes.dart:2758: // Don't omit a boolean conversion (which doesn't allow ...
5 years, 4 months ago (2015-07-27 12:17:26 UTC) #4
Johnni Winther
5 years, 4 months ago (2015-07-27 12:19:34 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
783ed933ff26bb5632b641ae01626fd1ffe00bc4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698