Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: pkg/compiler/lib/src/ssa/builder.dart

Issue 1259473005: Fix boolean conversion bug in dart2js + update JSRegExp accordingly. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Updated cf. comment Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/ssa/nodes.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/ssa/builder.dart
diff --git a/pkg/compiler/lib/src/ssa/builder.dart b/pkg/compiler/lib/src/ssa/builder.dart
index e3cb4b8d7da65c624767601c97c750cc201c07c7..0f5199287baf9082ade8007d022b1fbaabd75e3d 100644
--- a/pkg/compiler/lib/src/ssa/builder.dart
+++ b/pkg/compiler/lib/src/ssa/builder.dart
@@ -493,9 +493,7 @@ class LocalsHandler {
}
}
HInstruction value = directLocals[local];
- if (false && sourceInformation != null) {
- // TODO(johnniwinther): Enable this again when boolean conversions of
- // boolean type conversions are handled correctly.
+ if (sourceInformation != null) {
value = new HRef(value, sourceInformation);
builder.add(value);
}
« no previous file with comments | « no previous file | pkg/compiler/lib/src/ssa/nodes.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698