sdk/lib/_internal/js_runtime/lib/regexp_helper.dart - Issue 1259473005: Fix boolean conversion bug in dart2js + update JSRegExp accordingly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/js_runtime/lib/regexp_helper.dart

Issue 1259473005: Fix boolean conversion bug in dart2js + update JSRegExp accordingly. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Updated cf. comment Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/js_runtime/lib/regexp_helper.dart

diff --git a/sdk/lib/_internal/js_runtime/lib/regexp_helper.dart b/sdk/lib/_internal/js_runtime/lib/regexp_helper.dart

index e99810aa1da9f282514de2fff2b43a159ec7de5b..9b44116c08cb9de956679643545747993d6e6b04 100644

--- a/sdk/lib/_internal/js_runtime/lib/regexp_helper.dart

+++ b/sdk/lib/_internal/js_runtime/lib/regexp_helper.dart

@@ -82,8 +82,8 @@ class JSSyntaxRegExp implements RegExp {

static makeNative(

String source, bool multiLine, bool caseSensitive, bool global) {

checkString(source);

- String m = multiLine ? 'm' : '';

- String i = caseSensitive ? '' : 'i';

+ String m = multiLine == true ? 'm' : '';

+ String i = caseSensitive == true ? '' : 'i';

String g = global ? 'g' : '';

// We're using the JavaScript's try catch instead of the Dart one

// to avoid dragging in Dart runtime support just because of using

« no previous file with comments | « pkg/compiler/lib/src/ssa/nodes.dart ('k') | tests/compiler/dart2js/dart2js.status » ('j') | no next file with comments »