Split out a RunnerSuite class.

Split out a RunnerSuite class.

This class provides a place for runner-specific logic associated with a
suite that doesn't leak information to the backend code.

R=kevmoo@google.com

Committed: https://github.com/dart-lang/test/commit/90edd9e70cebd2f8cb78dd17e50444120bdd023e

[kevmoo, 2015-07-28 01:48:00]

LGTM w/ a few analyzer nits

https://codereview.chromium.org/1258163002/diff/1/lib/src/backend/suite.dart
File lib/src/backend/suite.dart (right):

https://codereview.chromium.org/1258163002/diff/1/lib/src/backend/suite.dart#...
lib/src/backend/suite.dart:7: import 'dart:async';
unused

https://codereview.chromium.org/1258163002/diff/1/lib/src/backend/suite.dart#...
lib/src/backend/suite.dart:10: import '../util/async_thunk.dart';
unused

https://codereview.chromium.org/1258163002/diff/1/lib/src/backend/suite.dart#...
lib/src/backend/suite.dart:11: import '../utils.dart';
unused

https://codereview.chromium.org/1258163002/diff/1/lib/src/runner/browser/brow...
File lib/src/runner/browser/browser_manager.dart (left):

https://codereview.chromium.org/1258163002/diff/1/lib/src/runner/browser/brow...
lib/src/runner/browser/browser_manager.dart:14: import
'../../backend/suite.dart';
loadSuite still refers to Suite in the future return type

https://codereview.chromium.org/1258163002/diff/1/lib/src/runner/loader.dart
File lib/src/runner/loader.dart (left):

https://codereview.chromium.org/1258163002/diff/1/lib/src/runner/loader.dart#...
lib/src/runner/loader.dart:17: import '../backend/suite.dart';
Suite is still referenced by a couple of methods

_loadBrowserFile, _loadVmFile

[nweiz, 2015-07-28 20:00:35]

Code review changes

[nweiz, 2015-07-28 20:01:21]

https://codereview.chromium.org/1258163002/diff/1/lib/src/backend/suite.dart
File lib/src/backend/suite.dart (right):

https://codereview.chromium.org/1258163002/diff/1/lib/src/backend/suite.dart#...
lib/src/backend/suite.dart:7: import 'dart:async';
On 2015/07/28 01:48:00, kevmoo wrote:
> unused

Done.

https://codereview.chromium.org/1258163002/diff/1/lib/src/backend/suite.dart#...
lib/src/backend/suite.dart:10: import '../util/async_thunk.dart';
On 2015/07/28 01:47:59, kevmoo wrote:
> unused

Done.

https://codereview.chromium.org/1258163002/diff/1/lib/src/backend/suite.dart#...
lib/src/backend/suite.dart:11: import '../utils.dart';
On 2015/07/28 01:47:59, kevmoo wrote:
> unused

Done.

https://codereview.chromium.org/1258163002/diff/1/lib/src/runner/browser/brow...
File lib/src/runner/browser/browser_manager.dart (left):

https://codereview.chromium.org/1258163002/diff/1/lib/src/runner/browser/brow...
lib/src/runner/browser/browser_manager.dart:14: import
'../../backend/suite.dart';
On 2015/07/28 01:48:00, kevmoo wrote:
> loadSuite still refers to Suite in the future return type

Done.

https://codereview.chromium.org/1258163002/diff/1/lib/src/runner/loader.dart
File lib/src/runner/loader.dart (left):

https://codereview.chromium.org/1258163002/diff/1/lib/src/runner/loader.dart#...
lib/src/runner/loader.dart:17: import '../backend/suite.dart';
On 2015/07/28 01:48:00, kevmoo wrote:
> Suite is still referenced by a couple of methods
> 
> _loadBrowserFile, _loadVmFile

Done.

[nweiz, 2015-07-28 20:02:06]

Committed patchset #2 (id:20001) manually as
90edd9e70cebd2f8cb78dd17e50444120bdd023e (presubmit successful).