Split out a RunnerSuite class.

lib/src/runner/loader.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.runner.loader;
 
 import 'dart:async';
 import 'dart:io';
 import 'dart:isolate';
 
 import 'package:analyzer/analyzer.dart';
 import 'package:path/path.dart' as p;
 import 'package:stack_trace/stack_trace.dart';
 
 import '../backend/invoker.dart';
 import '../backend/metadata.dart';
-import '../backend/suite.dart';

[kevmoo, 2015/07/28 01:48:00]

Suite is still referenced by a couple of methods

_loadBrowserFile, _loadVmFile

[nweiz, 2015/07/28 20:01:21]

Done.

 import '../backend/test_platform.dart';
 import '../util/async_thunk.dart';
 import '../util/dart.dart' as dart;
 import '../util/io.dart';
 import '../util/remote_exception.dart';
 import '../utils.dart';
 import 'browser/server.dart';
 import 'load_exception.dart';
 import 'load_suite.dart';
 import 'parse_metadata.dart';
+import 'runner_suite.dart';
 import 'vm/isolate_test.dart';
 
 /// A class for finding test files and loading them into a runnable form.
 class Loader {
   /// All platforms for which tests should be loaded.
   final List<TestPlatform> _platforms;
 
   /// Whether to enable colors for Dart compilation.
   final bool _color;
 
   /// Whether raw JavaScript stack traces should be used for tests that are
   /// compiled to JavaScript.
   final bool _jsTrace;
 
   /// Global metadata that applies to all test suites.
   final Metadata _metadata;
 
   /// The root directory that will be served for browser tests.
   final String _root;
 
   /// The package root to use for loading tests.
   final String _packageRoot;
 
   /// The URL for the `pub serve` instance to use to load tests.
   ///
   /// This is `null` if tests should be loaded from the filesystem.
   final Uri _pubServeUrl;
 
   /// All suites that have been created by the loader.
-  final _suites = new Set<Suite>();
+  final _suites = new Set<RunnerSuite>();
 
   /// The server that serves browser test pages.
   ///
   /// This is lazily initialized the first time it's accessed.
   Future<BrowserServer> get _browserServer {
     return _browserServerThunk.run(() {
       return BrowserServer.start(
           root: _root,
           packageRoot: _packageRoot,
           pubServeUrl: _pubServeUrl,
@@ skipping 84 matching lines @@
       return;
     }
 
     for (var platform in _platforms) {
       if (!suiteMetadata.testOn.evaluate(platform, os: currentOS)) continue;
 
       var metadata = suiteMetadata.forPlatform(platform, os: currentOS);
 
       // Don't load a skipped suite.
       if (metadata.skip) {
-        yield new LoadSuite.forSuite(new Suite([
+        yield new LoadSuite.forSuite(new RunnerSuite([
           new LocalTest(path, metadata, () {})
         ], path: path, platform: platform, metadata: metadata));
         continue;
       }
 
       var name = (platform.isJS ? "compiling " : "loading ") + path;
       yield new LoadSuite(name, () {
         return platform == TestPlatform.vm
             ? _loadVmFile(path, metadata)
             : _loadBrowserFile(path, platform, metadata);
@@ skipping 82 matching lines @@
         completer.completeError(
             new LoadException(path, asyncError.error),
             asyncError.stackTrace);
       } else {
         assert(response["type"] == "success");
         completer.complete(response["tests"]);
       }
     });
 
     try {
-      var suite = new Suite((await completer.future).map((test) {
+      var suite = new RunnerSuite((await completer.future).map((test) {
         var testMetadata = new Metadata.deserialize(test['metadata']);
         return new IsolateTest(test['name'], testMetadata, test['sendPort']);
       }),
           metadata: metadata,
           path: path,
           platform: TestPlatform.vm,
           os: currentOS,
           onClose: isolate.kill);
       _suites.add(suite);
       return suite;
     } finally {
       subscription.cancel();
     }
   }
 
   /// Closes the loader and releases all resources allocated by it.
   Future close() {
     return _closeThunk.run(() async {
       await Future.wait(_suites.map((suite) => suite.close()));
       _suites.clear();
 
       if (!_browserServerThunk.hasRun) return;
       await (await _browserServer).close();
     });
   }
 }