Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Unified Diff: test/runner/engine_test.dart

Issue 1258163002: Split out a RunnerSuite class. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Code review changes Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/test.dart ('k') | test/runner/load_suite_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/runner/engine_test.dart
diff --git a/test/runner/engine_test.dart b/test/runner/engine_test.dart
index ad4285c3431390460d9e700159ad44b026599e44..9e51d9e8f02becfe9766b57f3155a48be02a03de 100644
--- a/test/runner/engine_test.dart
+++ b/test/runner/engine_test.dart
@@ -4,8 +4,8 @@
import 'package:test/src/backend/declarer.dart';
import 'package:test/src/backend/state.dart';
-import 'package:test/src/backend/suite.dart';
import 'package:test/src/runner/engine.dart';
+import 'package:test/src/runner/runner_suite.dart';
import 'package:test/test.dart';
void main() {
@@ -22,8 +22,8 @@ void main() {
}
var engine = new Engine.withSuites([
- new Suite(declarer.tests.take(2)),
- new Suite(declarer.tests.skip(2))
+ new RunnerSuite(declarer.tests.take(2)),
+ new RunnerSuite(declarer.tests.skip(2))
]);
await engine.run();
@@ -44,7 +44,7 @@ void main() {
expect(testsRun, equals(4));
}), completes);
- engine.suiteSink.add(new Suite(declarer.tests));
+ engine.suiteSink.add(new RunnerSuite(declarer.tests));
engine.suiteSink.close();
});
@@ -55,7 +55,7 @@ void main() {
declarer.test("test ${i + 1}", expectAsync(() => testsRun++, max: 1));
}
- var engine = new Engine.withSuites([new Suite(declarer.tests)]);
+ var engine = new Engine.withSuites([new RunnerSuite(declarer.tests)]);
engine.onTestStarted.listen(expectAsync((liveTest) {
// [testsRun] should be one less than the test currently running.
@@ -75,7 +75,7 @@ void main() {
declarer.test("test ${i + 1}", () {});
}
- var engine = new Engine.withSuites([new Suite(declarer.tests)]);
+ var engine = new Engine.withSuites([new RunnerSuite(declarer.tests)]);
expect(engine.run(), completion(isTrue));
});
@@ -85,7 +85,7 @@ void main() {
}
declarer.test("failure", () => throw new TestFailure("oh no"));
- var engine = new Engine.withSuites([new Suite(declarer.tests)]);
+ var engine = new Engine.withSuites([new RunnerSuite(declarer.tests)]);
expect(engine.run(), completion(isFalse));
});
@@ -95,7 +95,7 @@ void main() {
}
declarer.test("failure", () => throw "oh no");
- var engine = new Engine.withSuites([new Suite(declarer.tests)]);
+ var engine = new Engine.withSuites([new RunnerSuite(declarer.tests)]);
expect(engine.run(), completion(isFalse));
});
@@ -110,7 +110,7 @@ void main() {
var bodyRun = false;
declarer.test("test", () => bodyRun = true, skip: true);
- var engine = new Engine.withSuites([new Suite(declarer.tests)]);
+ var engine = new Engine.withSuites([new RunnerSuite(declarer.tests)]);
await engine.run();
expect(bodyRun, isFalse);
});
@@ -118,7 +118,7 @@ void main() {
test("exposes a LiveTest that emits the correct states", () {
declarer.test("test", () {}, skip: true);
- var engine = new Engine.withSuites([new Suite(declarer.tests)]);
+ var engine = new Engine.withSuites([new RunnerSuite(declarer.tests)]);
engine.onTestStarted.listen(expectAsync((liveTest) {
expect(liveTest, same(engine.liveTests.single));
« no previous file with comments | « lib/test.dart ('k') | test/runner/load_suite_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698