Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 12543003: Use limited JavaStringBuilder implementation instead of Dart StringBuffer. (Closed)

Created:
7 years, 9 months ago by scheglov
Modified:
7 years, 9 months ago
Reviewers:
floitsch, pquitslund
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use limited JavaStringBuilder implementation instead of Dart StringBuffer. StringBuffer.clear() is deprecated and will be removed. R=pquitslund@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=19565

Patch Set 1 #

Total comments: 2

Patch Set 2 : Tweak JavaStringBuilder. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+631 lines, -509 lines) Patch
M editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart View 1 2 chunks +34 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/ObjectSemanticProcessor.java View 3 chunks +12 lines, -9 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/ObjectSemanticProcessorTest.java View 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/analyzer-experimental/lib/src/generated/ast.dart View 3 chunks +7 lines, -7 lines 0 comments Download
M pkg/analyzer-experimental/lib/src/generated/element.dart View 29 chunks +118 lines, -118 lines 0 comments Download
M pkg/analyzer-experimental/lib/src/generated/error.dart View 1 15 chunks +114 lines, -104 lines 0 comments Download
M pkg/analyzer-experimental/lib/src/generated/html_scanner.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer-experimental/lib/src/generated/java_core.dart View 1 2 chunks +34 lines, -0 lines 0 comments Download
M pkg/analyzer-experimental/lib/src/generated/parser.dart View 13 chunks +115 lines, -138 lines 0 comments Download
M pkg/analyzer-experimental/lib/src/generated/resolver.dart View 1 18 chunks +91 lines, -35 lines 0 comments Download
M pkg/analyzer-experimental/lib/src/generated/source.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M pkg/analyzer-experimental/test/generated/element_test.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M pkg/analyzer-experimental/test/generated/parser_test.dart View 11 chunks +52 lines, -44 lines 0 comments Download
M pkg/analyzer-experimental/test/generated/scanner_test.dart View 4 chunks +17 lines, -17 lines 0 comments Download
M pkg/analyzer-experimental/test/generated/test_support.dart View 3 chunks +18 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scheglov
7 years, 9 months ago (2013-03-06 16:32:43 UTC) #1
floitsch
DBC. https://codereview.chromium.org/12543003/diff/1/editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart File editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart (right): https://codereview.chromium.org/12543003/diff/1/editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart#newcode405 editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart:405: var s = sb.toString().substring(0, len); Note that the ...
7 years, 9 months ago (2013-03-06 16:52:18 UTC) #2
pquitslund
lgtm
7 years, 9 months ago (2013-03-06 17:05:27 UTC) #3
scheglov
https://codereview.chromium.org/12543003/diff/1/editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart File editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart (right): https://codereview.chromium.org/12543003/diff/1/editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart#newcode405 editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart:405: var s = sb.toString().substring(0, len); On 2013/03/06 16:52:18, floitsch ...
7 years, 9 months ago (2013-03-06 17:12:21 UTC) #4
scheglov
7 years, 9 months ago (2013-03-06 17:12:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r19565 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698