Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Unified Diff: pkg/analyzer-experimental/test/generated/test_support.dart

Issue 12543003: Use limited JavaStringBuilder implementation instead of Dart StringBuffer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Tweak JavaStringBuilder. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer-experimental/test/generated/scanner_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer-experimental/test/generated/test_support.dart
diff --git a/pkg/analyzer-experimental/test/generated/test_support.dart b/pkg/analyzer-experimental/test/generated/test_support.dart
index 3c129b731e581135ae83d08880ca2749a180000c..091619a51769acb69a9012fa26820e33f5ca73ed 100644
--- a/pkg/analyzer-experimental/test/generated/test_support.dart
+++ b/pkg/analyzer-experimental/test/generated/test_support.dart
@@ -89,7 +89,7 @@ class GatheringErrorListener implements AnalysisErrorListener {
* expected
*/
void assertErrors2(List<ErrorCode> expectedErrorCodes) {
- StringBuffer builder = new StringBuffer();
+ JavaStringBuilder builder = new JavaStringBuilder();
Map<ErrorCode, int> expectedCounts = new Map<ErrorCode, int>();
for (ErrorCode code in expectedErrorCodes) {
int count = expectedCounts[code];
@@ -122,15 +122,15 @@ class GatheringErrorListener implements AnalysisErrorListener {
}
if (actualCount != expectedCount) {
if (builder.length == 0) {
- builder.write("Expected ");
+ builder.append("Expected ");
} else {
- builder.write("; ");
+ builder.append("; ");
}
- builder.write(expectedCount);
- builder.write(" errors of type ");
- builder.write(code);
- builder.write(", found ");
- builder.write(actualCount);
+ builder.append(expectedCount);
+ builder.append(" errors of type ");
+ builder.append(code);
+ builder.append(", found ");
+ builder.append(actualCount);
}
}
for (MapEntry<ErrorCode, List<AnalysisError>> entry in getMapEntrySet(errorsByCode)) {
@@ -138,23 +138,23 @@ class GatheringErrorListener implements AnalysisErrorListener {
List<AnalysisError> actualErrors = entry.getValue();
int actualCount = actualErrors.length;
if (builder.length == 0) {
- builder.write("Expected ");
+ builder.append("Expected ");
} else {
- builder.write("; ");
+ builder.append("; ");
}
- builder.write("0 errors of type ");
- builder.write(code);
- builder.write(", found ");
- builder.write(actualCount);
- builder.write(" (");
+ builder.append("0 errors of type ");
+ builder.append(code);
+ builder.append(", found ");
+ builder.append(actualCount);
+ builder.append(" (");
for (int i = 0; i < actualErrors.length; i++) {
AnalysisError error = actualErrors[i];
if (i > 0) {
- builder.write(", ");
+ builder.append(", ");
}
- builder.write(error.offset);
+ builder.append(error.offset);
}
- builder.write(")");
+ builder.append(")");
}
if (builder.length > 0) {
JUnitTestCase.fail(builder.toString());
« no previous file with comments | « pkg/analyzer-experimental/test/generated/scanner_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698