pkg/analyzer-experimental/lib/src/generated/source.dart - Issue 12543003: Use limited JavaStringBuilder implementation instead of Dart StringBuffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer-experimental/lib/src/generated/source.dart

Issue 12543003: Use limited JavaStringBuilder implementation instead of Dart StringBuffer. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Tweak JavaStringBuilder. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analyzer-experimental/lib/src/generated/resolver.dart ('k') | pkg/analyzer-experimental/test/generated/element_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analyzer-experimental/lib/src/generated/source.dart

diff --git a/pkg/analyzer-experimental/lib/src/generated/source.dart b/pkg/analyzer-experimental/lib/src/generated/source.dart

index c6e8ac904ef3420537648e84464eb2903261afc8..97cfa9ad5135368d942c3124278482c4240f8968 100644

--- a/pkg/analyzer-experimental/lib/src/generated/source.dart

+++ b/pkg/analyzer-experimental/lib/src/generated/source.dart

@@ -365,12 +365,12 @@ class SourceRange {

bool startsIn(SourceRange otherRange) => otherRange.contains(_offset);

String toString() {

- StringBuffer builder = new StringBuffer();

- builder.write("[offset=");

- builder.write(_offset);

- builder.write(", length=");

- builder.write(_length);

- builder.write("]");

+ JavaStringBuilder builder = new JavaStringBuilder();

+ builder.append("[offset=");

+ builder.append(_offset);

+ builder.append(", length=");

+ builder.append(_length);

+ builder.append("]");

return builder.toString();

}