Load immediates via the constant pool on armv5te and armv6.

Load immediates via the constant pool on armv5te and armv6.

Fixes #23306

R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/23982c63e9acc4d09fb42fc8ac5500f56240675c

[regis, 2015-07-23 22:25:28]

regis@google.com changed reviewers:
+ zra@google.com

[regis, 2015-07-23 22:25:28]

Note that this implementation does not rely on an extra argument to all code
emitting assembler routines that could use the constant pool.

This can be ported later to other architectures to remove the extra argument.

[zra, 2015-07-23 22:46:00]

https://codereview.chromium.org/1250323002/diff/1/runtime/vm/assembler_arm.cc
File runtime/vm/assembler_arm.cc (right):

https://codereview.chromium.org/1250323002/diff/1/runtime/vm/assembler_arm.cc...
runtime/vm/assembler_arm.cc:1531: return object_pool_wrapper_.FindObject(smi);
Why not use ObjectPoolWrapper::FindImmediate() ? I think that's what arm64 uses.

https://codereview.chromium.org/1250323002/diff/1/runtime/vm/assembler_arm.cc...
runtime/vm/assembler_arm.cc:2757: if (constant_pool_allowed() &&
Here: https://codereview.chromium.org//1249623004 it looks like if you use
ObjectPoolWrapper::FindImmediate then you don't need the extra mask+retag.

[regis, 2015-07-23 23:07:31]

Thanks!

Please have another look.

https://codereview.chromium.org/1250323002/diff/1/runtime/vm/assembler_arm.cc
File runtime/vm/assembler_arm.cc (right):

https://codereview.chromium.org/1250323002/diff/1/runtime/vm/assembler_arm.cc...
runtime/vm/assembler_arm.cc:1531: return object_pool_wrapper_.FindObject(smi);
On 2015/07/23 22:45:59, zra wrote:
> Why not use ObjectPoolWrapper::FindImmediate() ? I think that's what arm64
uses.

Because I forked the code in May, when arm64 was still doing it this way :-)

Good point, thanks.

https://codereview.chromium.org/1250323002/diff/1/runtime/vm/assembler_arm.cc...
runtime/vm/assembler_arm.cc:2757: if (constant_pool_allowed() &&
On 2015/07/23 22:45:59, zra wrote:
> Here: https://codereview.chromium.org//1249623004 it looks like if you use
> ObjectPoolWrapper::FindImmediate then you don't need the extra mask+retag.

Done.

[zra, 2015-07-24 02:00:02]

lgtm

[regis, 2015-07-24 15:27:55]

Committed patchset #2 (id:20001) manually as
23982c63e9acc4d09fb42fc8ac5500f56240675c (presubmit successful).