runtime/vm/assembler_x64.cc - Issue 1250323002: Load immediates via the constant pool on armv5te and armv6.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/assembler_x64.cc

Issue 1250323002: Load immediates via the constant pool on armv5te and armv6. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: address comments Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/assembler_x64.cc

diff --git a/runtime/vm/assembler_x64.cc b/runtime/vm/assembler_x64.cc

index a14b6c596447a0395da1f127c2859f86146ccfc0..c397a13bc3c3d0a763600684ebdbb98cc6d23c45 100644

--- a/runtime/vm/assembler_x64.cc

+++ b/runtime/vm/assembler_x64.cc

@@ -2885,8 +2885,6 @@ bool Assembler::CanLoadImmediateFromPool(const Immediate& imm, Register pp) {

void Assembler::LoadImmediate(Register reg, const Immediate& imm, Register pp) {

if (CanLoadImmediateFromPool(imm, pp)) {

- // It's a 64-bit constant and we're not in the VM isolate, so load from

- // object pool.

int32_t offset = ObjectPool::element_offset(FindImmediate(imm.value()));

LoadWordFromPoolOffset(reg, pp, offset - kHeapObjectTag);

} else {

« no previous file with comments | « runtime/vm/assembler_arm.cc ('k') | runtime/vm/code_patcher_arm_test.cc » ('j') | no next file with comments »