Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 1249623004: VM: Improve loading of large immediates on ARM64. (Closed)

Created:
5 years, 5 months ago by Florian Schneider
Modified:
5 years, 5 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Improve loading of large immediates on ARM64. The object pool now already supports arbitrary immediates, so the special handling of immediates not tagged like smis can be removed. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/245b2b08ad1b1d547980e85f3315166362dd1a80

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M runtime/vm/assembler_arm64.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Florian Schneider
5 years, 5 months ago (2015-07-22 12:36:22 UTC) #2
Cutch
lgtm
5 years, 5 months ago (2015-07-22 16:55:10 UTC) #3
Florian Schneider
5 years, 5 months ago (2015-07-23 10:40:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
245b2b08ad1b1d547980e85f3315166362dd1a80 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698