Remove deprecated StringBuffer.add, addAll and addCharCode.

Remove deprecated StringBuffer.add, addAll and addCharCode.

Committed: https://code.google.com/p/dart/source/detail?r=19690

[floitsch, 2013-03-06 13:38:14]

https://codereview.chromium.org/12473003/diff/1/sdk/lib/io/buffer_list.dart
File sdk/lib/io/buffer_list.dart (right):

https://codereview.chromium.org/12473003/diff/1/sdk/lib/io/buffer_list.dart#n...
sdk/lib/io/buffer_list.dart:29: void write(List<int> buffer, [int offset = 0]) {
I needed to add this method so that the _BufferList could be used instead of a
STringBuffer.

[Anders Johnsen, 2013-03-06 14:31:00]

LGTM

https://codereview.chromium.org/12473003/diff/1/sdk/lib/io/buffer_list.dart
File sdk/lib/io/buffer_list.dart (right):

https://codereview.chromium.org/12473003/diff/1/sdk/lib/io/buffer_list.dart#n...
sdk/lib/io/buffer_list.dart:29: void write(List<int> buffer, [int offset = 0]) {
On 2013/03/06 13:38:14, floitsch wrote:
> I needed to add this method so that the _BufferList could be used instead of a
> STringBuffer.

SGTM, can we remove add then?

https://codereview.chromium.org/12473003/diff/1/utils/template/tree.dart
File utils/template/tree.dart (right):

https://codereview.chromium.org/12473003/diff/1/utils/template/tree.dart#newc...
utils/template/tree.dart:86: buf.write('\n');
writeln('')?

[scheglov, 2013-03-06 16:06:29]

Editor and samples LGTM

[srdjan, 2013-03-06 17:19:53]

VM libs LGTM

[Bob Nystrom, 2013-03-06 18:45:59]

pkg/ and utils/ LGTM.

[floitsch, 2013-03-08 13:08:13]

Committed patchset #1 manually as r19690 (presubmit successful).

[floitsch, 2013-03-08 13:18:39]

https://chromiumcodereview.appspot.com/12473003/diff/1/sdk/lib/io/buffer_list...
File sdk/lib/io/buffer_list.dart (right):

https://chromiumcodereview.appspot.com/12473003/diff/1/sdk/lib/io/buffer_list...
sdk/lib/io/buffer_list.dart:29: void write(List<int> buffer, [int offset = 0]) {
On 2013/03/06 14:31:00, Anders Johnsen wrote:
> On 2013/03/06 13:38:14, floitsch wrote:
> > I needed to add this method so that the _BufferList could be used instead of
a
> > STringBuffer.
> 
> SGTM, can we remove add then?

Maybe. I don't know how _BufferList is otherwise used. I left it as is. If
_BufferList is only here to be an alternative to StringBuffer, then it should
probably implement the StringSink interface.

https://chromiumcodereview.appspot.com/12473003/diff/1/utils/template/tree.dart
File utils/template/tree.dart (right):

https://chromiumcodereview.appspot.com/12473003/diff/1/utils/template/tree.da...
utils/template/tree.dart:86: buf.write('\n');
On 2013/03/06 14:31:00, Anders Johnsen wrote:
> writeln('')?

Missed it before committing...
Yes "writeln" would work, but it's not a big deal.