Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Unified Diff: runtime/lib/string_base.dart

Issue 12473003: Remove deprecated StringBuffer.add, addAll and addCharCode. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/lib/string_base.dart
diff --git a/runtime/lib/string_base.dart b/runtime/lib/string_base.dart
index 8ed74b6413dd969022f5494f14818512e1c5c3b0..ec8cd65b5a61ae14897ddc8db1a20b2f732cdb48 100644
--- a/runtime/lib/string_base.dart
+++ b/runtime/lib/string_base.dart
@@ -254,11 +254,11 @@ class _StringBase {
Iterator iterator = pattern.allMatches(this).iterator;
if (iterator.moveNext()) {
Match match = iterator.current;
- buffer..add(this.substring(startIndex, match.start))
- ..add(replacement);
+ buffer..write(this.substring(startIndex, match.start))
+ ..write(replacement);
startIndex = match.end;
}
- return (buffer..add(this.substring(startIndex))).toString();
+ return (buffer..write(this.substring(startIndex))).toString();
}
String replaceAll(Pattern pattern, String replacement) {
@@ -272,11 +272,11 @@ class _StringBase {
StringBuffer buffer = new StringBuffer();
int startIndex = 0;
for (Match match in pattern.allMatches(this)) {
- buffer..add(this.substring(startIndex, match.start))
- ..add(replacement);
+ buffer..write(this.substring(startIndex, match.start))
+ ..write(replacement);
startIndex = match.end;
}
- return (buffer..add(this.substring(startIndex))).toString();
+ return (buffer..write(this.substring(startIndex))).toString();
}
String replaceAllMapped(Pattern pattern, String replace(Match match)) {
@@ -292,9 +292,9 @@ class _StringBase {
StringBuffer buffer = new StringBuffer();
int length = this.length;
int i = 0;
- buffer.add(onNonMatch(""));
+ buffer.write(onNonMatch(""));
while (i < length) {
- buffer.add(onMatch(new _StringMatch(i, this, "")));
+ buffer.write(onMatch(new _StringMatch(i, this, "")));
// Special case to avoid splitting a surrogate pair.
int code = this.codeUnitAt(i);
if ((code & ~0x3FF) == 0xD800 && length > i + 1) {
@@ -302,16 +302,16 @@ class _StringBase {
code = this.codeUnitAt(i + 1);
if ((code & ~0x3FF) == 0xDC00) {
// Matching trailing surrogate.
- buffer.add(onNonMatch(this.substring(i, i + 2)));
+ buffer.write(onNonMatch(this.substring(i, i + 2)));
i += 2;
continue;
}
}
- buffer.add(onNonMatch(this[i]));
+ buffer.write(onNonMatch(this[i]));
i++;
}
- buffer.add(onMatch(new _StringMatch(i, this, "")));
- buffer.add(onNonMatch(""));
+ buffer.write(onMatch(new _StringMatch(i, this, "")));
+ buffer.write(onNonMatch(""));
return buffer.toString();
}
@@ -332,11 +332,11 @@ class _StringBase {
StringBuffer buffer = new StringBuffer();
int startIndex = 0;
for (Match match in pattern.allMatches(this)) {
- buffer.add(onNonMatch(this.substring(startIndex, match.start)));
- buffer.add(onMatch(match).toString());
+ buffer.write(onNonMatch(this.substring(startIndex, match.start)));
+ buffer.write(onMatch(match).toString());
startIndex = match.end;
}
- buffer.add(onNonMatch(this.substring(startIndex)));
+ buffer.write(onNonMatch(this.substring(startIndex)));
return buffer.toString();
}

Powered by Google App Engine
This is Rietveld 408576698