sdk/lib/_internal/compiler/implementation/lib/js_helper.dart - Issue 12473003: Remove deprecated StringBuffer.add, addAll and addCharCode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/lib/js_helper.dart

Issue 12473003: Remove deprecated StringBuffer.add, addAll and addCharCode. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/lib/core_patch.dart ('k') | sdk/lib/_internal/compiler/implementation/lib/string_helper.dart » ('j') | sdk/lib/io/buffer_list.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/lib/js_helper.dart

diff --git a/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart b/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart

index f9a3af7c6ad148cf9a58ef529b71e0abd36bb8bc..b21cb20124ee394f9cf805b2c7a41b06208f0dcc 100644

--- a/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart

+++ b/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart

@@ -515,7 +515,7 @@ class Primitives {

// sort implementation, we use the JavaScript one instead.

JS('void', '#.sort()', listOfNamedArguments);

listOfNamedArguments.forEach((String name) {

- buffer.add('\$$name');

+ buffer.write('\$$name');

arguments.add(namedArguments[name]);

});

}

@@ -1455,10 +1455,10 @@ String joinArguments(var types, int startIndex) {

if (firstArgument) {

firstArgument = false;

} else {

- buffer. add(', ');

+ buffer.write(', ');

}

var argument = types[index];

- buffer.add(runtimeTypeToString(argument));

+ buffer.write(runtimeTypeToString(argument));

}

return buffer.toString();

}