Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1245573002: dart2js: Use JS_GET_NAME instead of magic constant for catch-all function. (Closed)

Created:
5 years, 5 months ago by floitsch
Modified:
5 years, 5 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: Use JS_GET_NAME instead of magic constant for catch-all function. R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/fb4633a1c5f3d0c0db7b7a1905621534855ef1a6

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added a comment on where the catch-all property for closures comes from. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 1 1 chunk +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart View 1 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/js_helper.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
floitsch
https://codereview.chromium.org/1245573002/diff/1/sdk/lib/_internal/js_runtime/lib/js_helper.dart File sdk/lib/_internal/js_runtime/lib/js_helper.dart (right): https://codereview.chromium.org/1245573002/diff/1/sdk/lib/_internal/js_runtime/lib/js_helper.dart#newcode1165 sdk/lib/_internal/js_runtime/lib/js_helper.dart:1165: JS_GET_NAME(JsGetName.CALL_CATCH_ALL)); Another use is here https://codereview.chromium.org/1245573002/diff/1/sdk/lib/_internal/js_runtime/lib/js_helper.dart#newcode1188 sdk/lib/_internal/js_runtime/lib/js_helper.dart:1188: JS_GET_NAME(JsGetName.CALL_CATCH_ALL)); and ...
5 years, 5 months ago (2015-07-20 12:23:00 UTC) #2
karlklose
LGTM.
5 years, 5 months ago (2015-07-20 12:23:52 UTC) #3
floitsch
Added a comment, where the catch-all property for closures is installed.
5 years, 5 months ago (2015-07-20 12:53:32 UTC) #4
floitsch
5 years, 5 months ago (2015-07-20 12:54:03 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
fb4633a1c5f3d0c0db7b7a1905621534855ef1a6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698