pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart - Issue 1245573002: dart2js: Use JS_GET_NAME instead of magic constant for catch-all function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart

Issue 1245573002: dart2js: Use JS_GET_NAME instead of magic constant for catch-all function. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Added a comment on where the catch-all property for closures comes from. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart

diff --git a/pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart b/pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart

index 7f67343ec0780e52f6fa0128c7b866c04699932b..02a0ac2234de42c8886819b54f52c5a3f994de62 100644

--- a/pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart

+++ b/pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart

@@ -8,7 +8,9 @@ import 'dart:convert';

import 'dart:collection' show HashMap;

import 'package:js_runtime/shared/embedded_names.dart' as embeddedNames;

-import 'package:js_runtime/shared/embedded_names.dart' show JsBuiltin;

+import 'package:js_runtime/shared/embedded_names.dart' show

+ JsBuiltin,

+ JsGetName;

import '../js_emitter.dart' hide Emitter;

import '../js_emitter.dart' as js_emitter show Emitter;

« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart » ('j') | no next file with comments »