Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Side by Side Diff: pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart

Issue 1245573002: dart2js: Use JS_GET_NAME instead of magic constant for catch-all function. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Added a comment on where the catch-all property for closures comes from. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library dart2js.js_emitter.full_emitter; 5 library dart2js.js_emitter.full_emitter;
6 6
7 import 'dart:convert'; 7 import 'dart:convert';
8 import 'dart:collection' show HashMap; 8 import 'dart:collection' show HashMap;
9 9
10 import 'package:js_runtime/shared/embedded_names.dart' as embeddedNames; 10 import 'package:js_runtime/shared/embedded_names.dart' as embeddedNames;
11 import 'package:js_runtime/shared/embedded_names.dart' show JsBuiltin; 11 import 'package:js_runtime/shared/embedded_names.dart' show
12 JsBuiltin,
13 JsGetName;
12 14
13 import '../js_emitter.dart' hide Emitter; 15 import '../js_emitter.dart' hide Emitter;
14 import '../js_emitter.dart' as js_emitter show Emitter; 16 import '../js_emitter.dart' as js_emitter show Emitter;
15 17
16 import '../model.dart'; 18 import '../model.dart';
17 import '../program_builder/program_builder.dart'; 19 import '../program_builder/program_builder.dart';
18 20
19 import '../../common.dart'; 21 import '../../common.dart';
20 22
21 import '../../constants/values.dart'; 23 import '../../constants/values.dart';
(...skipping 2073 matching lines...) Expand 10 before | Expand all | Expand 10 after
2095 for (Element element in compiler.enqueuer.codegen.newlyEnqueuedElements) { 2097 for (Element element in compiler.enqueuer.codegen.newlyEnqueuedElements) {
2096 if (element.isInstanceMember) { 2098 if (element.isInstanceMember) {
2097 cachedClassBuilders.remove(element.enclosingClass); 2099 cachedClassBuilders.remove(element.enclosingClass);
2098 2100
2099 nativeEmitter.cachedBuilders.remove(element.enclosingClass); 2101 nativeEmitter.cachedBuilders.remove(element.enclosingClass);
2100 2102
2101 } 2103 }
2102 } 2104 }
2103 } 2105 }
2104 } 2106 }
OLDNEW
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698