Updates to the new analyzer to help make the try bot happy.

Updates to the new analyzer to help make the try bot happy.
Committed: https://code.google.com/p/dart/source/detail?r=19946

[devoncarew, 2013-03-12 22:06:41]

https://codereview.chromium.org/12438007/diff/1/sdk/bin/analyzer.bat
File sdk/bin/analyzer.bat (left):

https://codereview.chromium.org/12438007/diff/1/sdk/bin/analyzer.bat#oldcode25
sdk/bin/analyzer.bat:25: java -jar %JAR_FILE% %arguments%"
I assume this trailing quote was accidental? I haven't tried to run this on my
windows box yet.

[Brian Wilkerson, 2013-03-13 00:16:21]

The Java changes LGTM.

[ricow1, 2013-03-13 07:06:05]

LGTM with a few comments

https://codereview.chromium.org/12438007/diff/1/sdk/bin/analyzer
File sdk/bin/analyzer (right):

https://codereview.chromium.org/12438007/diff/1/sdk/bin/analyzer#newcode22
sdk/bin/analyzer:22: BIN_DIR="$(follow_links "$(cd "${PROG_NAME%/*}" ; pwd
-P)")"
could we just use CUR_DIR below, it is the same as this

https://codereview.chromium.org/12438007/diff/1/tools/testing/dart/test_suite...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/12438007/diff/1/tools/testing/dart/test_suite...
tools/testing/dart/test_suite.dart:1233: args.add('--machine');
This will remove the --error_format from dartc - in here analyzer means any
analyzer. if you want to do something specific to the new analyzer use
configuration['compiler'] == 'new_analyzer'

[devoncarew, 2013-03-13 17:04:50]

Thanks for the reviews!

https://codereview.chromium.org/12438007/diff/1/sdk/bin/analyzer
File sdk/bin/analyzer (right):

https://codereview.chromium.org/12438007/diff/1/sdk/bin/analyzer#newcode22
sdk/bin/analyzer:22: BIN_DIR="$(follow_links "$(cd "${PROG_NAME%/*}" ; pwd
-P)")"
On 2013/03/13 07:06:05, ricow1 wrote:
> could we just use CUR_DIR below, it is the same as this

Done.

https://codereview.chromium.org/12438007/diff/1/tools/testing/dart/test_suite...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/12438007/diff/1/tools/testing/dart/test_suite...
tools/testing/dart/test_suite.dart:1233: args.add('--machine');
On 2013/03/13 07:06:05, ricow1 wrote:
> This will remove the --error_format from dartc - in here analyzer means any
> analyzer. if you want to do something specific to the new analyzer use
> configuration['compiler'] == 'new_analyzer'

I actually added support for --machine to both dartc and the new analyzer, so I
figure I'll just pass the same flag in for both.

[devoncarew, 2013-03-13 17:06:28]

Committed patchset #1 manually as r19946 (presubmit successful).