Updates to the new analyzer to help make the try bot happy.

tools/testing/dart/test_suite.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Classes and methods for enumerating and preparing tests.
  *
  * This library includes:
  *
  * - Creating tests by listing all the Dart files in certain directories,
@@ skipping 165 matching lines @@
     var suffix = getExecutableSuffix(configuration['compiler']);
     switch (configuration['compiler']) {
       case 'none':
         if (useSdk) {
           return '$buildDir/dart-sdk/bin/dart$suffix';
         }
         return '$buildDir/dart$suffix';
       case 'dartc':
         return '$buildDir/analyzer/bin/dart_analyzer$suffix';
       case 'new_analyzer':
-        var prefix = 'sdk/bin/';
+        var prefix = 'sdk/bin';
         return '$prefix/analyzer$suffix';
       default:
         throw "Unknown executable for: ${configuration['compiler']}";
     }
   }
 
   /**
    * The file name of the d8 executable.
    */
   String get d8FileName {
@@ skipping 1026 matching lines @@
 
   List<String> commonArgumentsFromFile(Path filePath, Map optionsFromFile) {
     List args = TestUtils.standardOptions(configuration);
 
     String packageRoot = packageRootArgument(optionsFromFile['packageRoot']);
     if (packageRoot != null) {
       args.add(packageRoot);
     }
     args.addAll(additionalOptions(filePath));
     if (configuration['analyzer']) {
-      args.add('--error_format');
-      args.add('machine');
+      args.add('--machine');

[ricow1, 2013/03/13 07:06:05]

This will remove the --error_format from dartc - in here analyzer means any
analyzer. if you want to do something specific to the new analyzer use
configuration['compiler'] == 'new_analyzer'

[devoncarew, 2013/03/13 17:04:50]

I actually added support for --machine to both dartc and the new analyzer, so I
figure I'll just pass the same flag in for both.

     }
 
     bool isMultitest = optionsFromFile["isMultitest"];
     List<String> dartOptions = optionsFromFile["dartOptions"];
     List<List<String>> vmOptionsList = getVmOptions(optionsFromFile);
     Expect.isTrue(!isMultitest || dartOptions == null);
     if (dartOptions == null) {
       args.add(filePath.toNativePath());
     } else {
       var executable_name = dartOptions[0];
@@ skipping 716 matching lines @@
  * $pass tests are expected to pass
  * $failOk tests are expected to fail that we won't fix
  * $fail tests are expected to fail that we should fix
  * $crash tests are expected to crash that we should fix
  * $timeout tests are allowed to timeout
  * $compileErrorSkip tests are skipped on browsers due to compile-time error
 """;
     print(report);
    }
 }