editor/tools/plugins/com.google.dart.command.analyze/src/com/google/dart/command/analyze/AnalyzerImpl.java - Issue 12438007: Updates to the new analyzer to help make the try bot happy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: editor/tools/plugins/com.google.dart.command.analyze/src/com/google/dart/command/analyze/AnalyzerImpl.java

Issue 12438007: Updates to the new analyzer to help make the try bot happy. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/CommandLineOptions.java ('k') | editor/tools/plugins/com.google.dart.command.analyze/src/com/google/dart/command/analyze/AnalyzerMain.java » ('j') | sdk/bin/analyzer » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: editor/tools/plugins/com.google.dart.command.analyze/src/com/google/dart/command/analyze/AnalyzerImpl.java

===================================================================

--- editor/tools/plugins/com.google.dart.command.analyze/src/com/google/dart/command/analyze/AnalyzerImpl.java (revision 19891)

+++ editor/tools/plugins/com.google.dart.command.analyze/src/com/google/dart/command/analyze/AnalyzerImpl.java (working copy)

@@ -52,9 +52,13 @@

}

private AnalyzerOptions options;

+ private DartSdk sdk;

public AnalyzerImpl(AnalyzerOptions options) {

this.options = options;

+ // This sdk is shared between multiple runs of the analyzer.

+ sdk = new DartSdk(options.getDartSdkPath());

}

/**

@@ -72,9 +76,6 @@

throw new IllegalArgumentException("sourceFile cannot be null");

}

- // TODO(devoncarew): can we share this SDK when running in batch mode?

- DartSdk sdk = new DartSdk(options.getDartSdkPath());

AnalysisContext context = AnalysisEngine.getInstance().createAnalysisContext();

SourceFactory sourceFactory;