Issue 12390039: Adds vstm, vldm to ARM simulator, assembler, disassembler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12390039: Adds vstm, vldm to ARM simulator, assembler, disassembler (Closed)

Created:
7 years, 9 months ago by zra

Modified:
7 years, 9 months ago

Reviewers:
regis, srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Adds vstm, vldm to ARM simulator, assembler, disassembler Committed: https://code.google.com/p/dart/source/detail?r=19404

Patch Set 3 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+531 lines, -0 lines)			Patch
M	runtime/vm/assembler_arm.h	View	1 2	2 chunks	+24 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_arm.cc	View	1 2	2 chunks	+78 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_arm_test.cc	View	1 2	1 chunk	+321 lines, -0 lines	0 comments	Download
M	runtime/vm/constants_arm.h	View	1 2	1 chunk	+8 lines, -0 lines	0 comments	Download
M	runtime/vm/disassembler_arm.cc	View	1 2	3 chunks	+40 lines, -0 lines	0 comments	Download
M	runtime/vm/simulator_arm.cc	View	1 2	4 chunks	+60 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM https://codereview.chromium.org/12390039/diff/5002/runtime/vm/assembler_arm.cc File runtime/vm/assembler_arm.cc (right): https://codereview.chromium.org/12390039/diff/5002/runtime/vm/assembler_arm.cc#newcode783 runtime/vm/assembler_arm.cc:783: Change the order here as well. https://codereview.chromium.org/12390039/diff/5002/runtime/vm/assembler_arm.h File ...

7 years, 9 months ago (2013-03-04 17:25:40 UTC) #2

zra

7 years, 9 months ago (2013-03-04 17:45:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r19404 (presubmit successful).

Expand Messages | Collapse Messages

Issue 12390039: Adds vstm, vldm to ARM simulator, assembler, disassembler (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages