Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 12340036: Android improvements: (Closed)

Created:
7 years, 10 months ago by gram
Modified:
7 years, 6 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Android improvements: - support for ImageElement with PNG files - added a 'dirty' flag to many canvas APIs to reduce the need to swap GL buffers - lifecycle improvements (pause/resume/activate/deactivate). Still not perfect but much better than it was. Committed: https://code.google.com/p/dart/source/detail?r=18934

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 3

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8017 lines, -231 lines) Patch
M runtime/embedders/openglui/android/android_graphics_handler.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/embedders/openglui/android/android_graphics_handler.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/embedders/openglui/android/android_sound_handler.h View 2 chunks +3 lines, -0 lines 0 comments Download
M runtime/embedders/openglui/android/android_sound_handler.cc View 2 chunks +37 lines, -19 lines 0 comments Download
M runtime/embedders/openglui/android/eventloop.h View 2 chunks +2 lines, -4 lines 0 comments Download
M runtime/embedders/openglui/android/eventloop.cc View 2 chunks +190 lines, -58 lines 0 comments Download
M runtime/embedders/openglui/android/main.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/embedders/openglui/common/canvas_context.h View 7 chunks +17 lines, -3 lines 0 comments Download
M runtime/embedders/openglui/common/canvas_context.cc View 1 2 6 chunks +56 lines, -12 lines 0 comments Download
M runtime/embedders/openglui/common/dart_host.h View 1 chunk +8 lines, -19 lines 0 comments Download
M runtime/embedders/openglui/common/dart_host.cc View 1 2 chunks +45 lines, -56 lines 0 comments Download
M runtime/embedders/openglui/common/extension.cc View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/embedders/openglui/common/gl.dart View 2 chunks +6 lines, -2 lines 0 comments Download
M runtime/embedders/openglui/common/graphics_handler.h View 2 chunks +9 lines, -1 line 0 comments Download
M runtime/embedders/openglui/common/graphics_handler.cc View 4 chunks +34 lines, -10 lines 0 comments Download
M runtime/embedders/openglui/common/lifecycle_handler.h View 1 chunk +8 lines, -11 lines 0 comments Download
M runtime/embedders/openglui/common/log.h View 1 chunk +10 lines, -2 lines 0 comments Download
M runtime/embedders/openglui/common/sound_handler.h View 1 chunk +8 lines, -0 lines 0 comments Download
M runtime/embedders/openglui/common/vm_glue.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/embedders/openglui/common/vm_glue.cc View 1 2 5 chunks +16 lines, -10 lines 0 comments Download
M runtime/embedders/openglui/emulator/emulator_embedder.cc View 1 3 chunks +21 lines, -1 line 0 comments Download
M runtime/embedders/openglui/emulator/emulator_graphics_handler.cc View 2 chunks +1 line, -2 lines 0 comments Download
M runtime/embedders/openglui/openglui_embedder.gypi View 1 2 chunks +2 lines, -0 lines 0 comments Download
M samples/openglui/android/custom_rules.xml View 1 chunk +5 lines, -0 lines 0 comments Download
M samples/openglui/emulator/emulator.gyp View 3 chunks +23 lines, -4 lines 0 comments Download
A samples/openglui/src/chrome.hex View 1 chunk +7444 lines, -0 lines 0 comments Download
M samples/openglui/src/openglui_canvas_tests.dart View 1 2 5 chunks +60 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
gram
7 years, 10 months ago (2013-02-22 21:52:32 UTC) #1
vsm
LGTM with minor comments https://codereview.chromium.org/12340036/diff/1/runtime/embedders/openglui/android/main.cc File runtime/embedders/openglui/android/main.cc (right): https://codereview.chromium.org/12340036/diff/1/runtime/embedders/openglui/android/main.cc#newcode15 runtime/embedders/openglui/android/main.cc:15: const char* resource_path = "/data/data/com.google.dartndk/app_dart"; ...
7 years, 10 months ago (2013-02-23 00:25:25 UTC) #2
gram
7 years, 10 months ago (2013-02-23 00:38:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r18934.

Powered by Google App Engine
This is Rietveld 408576698