Add path.joinAll.

Add path.joinAll.

Committed: https://code.google.com/p/dart/source/detail?r=18860

[Bob Nystrom, 2013-02-21 22:03:27]

https://codereview.chromium.org/12314047/diff/1/pkg/path/lib/path.dart
File pkg/path/lib/path.dart (right):

https://codereview.chromium.org/12314047/diff/1/pkg/path/lib/path.dart#newcod...
pkg/path/lib/path.dart:129: /// For a fixed number of parts, [join] usually
terser.
"usually" -> "is usually".

https://codereview.chromium.org/12314047/diff/1/pkg/path/lib/path.dart#newcod...
pkg/path/lib/path.dart:359: /// For a fixed number of parts, [join] usually
terser.
Ditto.

https://codereview.chromium.org/12314047/diff/1/pkg/path/test/path_posix_test...
File pkg/path/test/path_posix_test.dart (right):

https://codereview.chromium.org/12314047/diff/1/pkg/path/test/path_posix_test...
pkg/path/test/path_posix_test.dart:182: test('disallows intermediate nulls', ()
{
I think it should disallow trailing nulls too.

[nweiz, 2013-02-21 22:19:25]

https://codereview.chromium.org/12314047/diff/1/pkg/path/lib/path.dart
File pkg/path/lib/path.dart (right):

https://codereview.chromium.org/12314047/diff/1/pkg/path/lib/path.dart#newcod...
pkg/path/lib/path.dart:129: /// For a fixed number of parts, [join] usually
terser.
On 2013/02/21 22:03:27, Bob Nystrom wrote:
> "usually" -> "is usually".

Done.

https://codereview.chromium.org/12314047/diff/1/pkg/path/lib/path.dart#newcod...
pkg/path/lib/path.dart:359: /// For a fixed number of parts, [join] usually
terser.
On 2013/02/21 22:03:27, Bob Nystrom wrote:
> Ditto.

Done.

https://codereview.chromium.org/12314047/diff/1/pkg/path/test/path_posix_test...
File pkg/path/test/path_posix_test.dart (right):

https://codereview.chromium.org/12314047/diff/1/pkg/path/test/path_posix_test...
pkg/path/test/path_posix_test.dart:182: test('disallows intermediate nulls', ()
{
On 2013/02/21 22:03:27, Bob Nystrom wrote:
> I think it should disallow trailing nulls too.

I actually meant to remove this test. I don't think it should explicitly handle
nulls at all, any more than any other method that accepts a conceptually
non-nullable argument.

[Bob Nystrom, 2013-02-21 22:40:08]

On 2013/02/21 22:19:25, nweiz wrote:
> https://codereview.chromium.org/12314047/diff/1/pkg/path/lib/path.dart
> File pkg/path/lib/path.dart (right):
> 
>
https://codereview.chromium.org/12314047/diff/1/pkg/path/lib/path.dart#newcod...
> pkg/path/lib/path.dart:129: /// For a fixed number of parts, [join] usually
> terser.
> On 2013/02/21 22:03:27, Bob Nystrom wrote:
> > "usually" -> "is usually".
> 
> Done.
> 
>
https://codereview.chromium.org/12314047/diff/1/pkg/path/lib/path.dart#newcod...
> pkg/path/lib/path.dart:359: /// For a fixed number of parts, [join] usually
> terser.
> On 2013/02/21 22:03:27, Bob Nystrom wrote:
> > Ditto.
> 
> Done.
> 
>
https://codereview.chromium.org/12314047/diff/1/pkg/path/test/path_posix_test...
> File pkg/path/test/path_posix_test.dart (right):
> 
>
https://codereview.chromium.org/12314047/diff/1/pkg/path/test/path_posix_test...
> pkg/path/test/path_posix_test.dart:182: test('disallows intermediate nulls',
()
> {
> On 2013/02/21 22:03:27, Bob Nystrom wrote:
> > I think it should disallow trailing nulls too.
> 
> I actually meant to remove this test. I don't think it should explicitly
handle
> nulls at all, any more than any other method that accepts a conceptually
> non-nullable argument.

Works for me.

LGTM.

[nweiz, 2013-02-21 22:48:38]

Committed patchset #2 manually as r18860 (presubmit successful).