Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1064)

Unified Diff: pkg/path/test/path_windows_test.dart

Issue 12314047: Add path.joinAll. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/path/test/path_posix_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/path/test/path_windows_test.dart
diff --git a/pkg/path/test/path_windows_test.dart b/pkg/path/test/path_windows_test.dart
index 12e370b85cf9cd76bbcea19efb4575eb6207f6eb..8164224d0f2a34f781fbb2f7b4d848ba055a8541 100644
--- a/pkg/path/test/path_windows_test.dart
+++ b/pkg/path/test/path_windows_test.dart
@@ -180,6 +180,26 @@ main() {
});
});
+ group('joinAll', () {
+ test('allows more than eight parts', () {
+ expect(builder.joinAll(['a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i']),
+ r'a\b\c\d\e\f\g\h\i');
+ });
+
+ test('does not add separator if a part ends or begins in one', () {
+ expect(builder.joinAll([r'a\', 'b', r'c\', 'd']), r'a\b\c\d');
+ expect(builder.joinAll(['a/', 'b']), r'a/b');
+ expect(builder.joinAll(['a', '/b']), 'a/b');
+ expect(builder.joinAll(['a', r'\b']), r'a\b');
+ });
+
+ test('ignores parts before an absolute path', () {
+ expect(builder.joinAll(['a', '/b', '/c', 'd']), r'a/b/c\d');
+ expect(builder.joinAll(['a', r'c:\b', 'c', 'd']), r'c:\b\c\d');
+ expect(builder.joinAll(['a', r'\\b', r'\\c', 'd']), r'\\c\d');
+ });
+ });
+
group('split', () {
test('simple cases', () {
expect(builder.split(''), []);
« no previous file with comments | « pkg/path/test/path_posix_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698