Add path.joinAll.

pkg/path/test/path_posix_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library path_test;
 
 import 'dart:io' as io;
 
 import 'package:unittest/unittest.dart';
 import 'package:path/path.dart' as path;
@@ skipping 143 matching lines @@
       expect(builder.join('a', null), equals('a'));
       expect(builder.join('a', 'b', 'c', null, null), equals('a/b/c'));
     });
 
     test('disallows intermediate nulls', () {
       expect(() => builder.join('a', null, 'b'), throwsArgumentError);
       expect(() => builder.join(null, 'a'), throwsArgumentError);
     });
   });
 
+  group('joinAll', () {
+    test('allows more than eight parts', () {
+      expect(builder.joinAll(['a', 'b', 'c', 'd', 'e', 'f', 'g', 'h', 'i']),
+          'a/b/c/d/e/f/g/h/i');
+    });
+
+    test('does not add separator if a part ends in one', () {
+      expect(builder.joinAll(['a/', 'b', 'c/', 'd']), 'a/b/c/d');
+      expect(builder.joinAll(['a\\', 'b']), r'a\/b');
+    });
+
+    test('ignores parts before an absolute path', () {
+      expect(builder.joinAll(['a', '/', 'b', 'c']), '/b/c');
+      expect(builder.joinAll(['a', '/b', '/c', 'd']), '/c/d');
+      expect(builder.joinAll(['a', r'c:\b', 'c', 'd']), r'a/c:\b/c/d');
+      expect(builder.joinAll(['a', r'\\b', 'c', 'd']), r'a/\\b/c/d');
+    });
+
+    test('disallows intermediate nulls', () {

[Bob Nystrom, 2013/02/21 22:03:27]

I think it should disallow trailing nulls too.

[nweiz, 2013/02/21 22:19:25]

I actually meant to remove this test. I don't think it should explicitly handle
nulls at all, any more than any other method that accepts a conceptually
non-nullable argument.

+      expect(() => builder.joinAll(['a', null, 'b']), throwsArgumentError);
+      expect(() => builder.joinAll([null, 'a']), throwsArgumentError);
+    });
+  });
+
   group('split', () {
     test('simple cases', () {
       expect(builder.split(''), []);
       expect(builder.split('.'), ['.']);
       expect(builder.split('..'), ['..']);
       expect(builder.split('foo'), equals(['foo']));
       expect(builder.split('foo/bar.txt'), equals(['foo', 'bar.txt']));
       expect(builder.split('foo/bar/baz'), equals(['foo', 'bar', 'baz']));
       expect(builder.split('foo/../bar/./baz'),
           equals(['foo', '..', 'bar', '.', 'baz']));
@@ skipping 190 matching lines @@
     expect(builder.withoutExtension('a/.'), 'a/.');
     expect(builder.withoutExtension('a/.b'), 'a/.b');
     expect(builder.withoutExtension('a.b/c'), 'a.b/c');
     expect(builder.withoutExtension(r'a.b\c'), r'a');
     expect(builder.withoutExtension(r'a/b\c'), r'a/b\c');
     expect(builder.withoutExtension(r'a/b\c.d'), r'a/b\c');
     expect(builder.withoutExtension('a/b.c/'), 'a/b/');
     expect(builder.withoutExtension('a/b.c//'), 'a/b//');
   });
 }