Issue 12313014: Make some name validation errors warnings.

Issue 12313014: Make some name validation errors warnings. (Closed)

Created:
7 years, 10 months ago by Bob Nystrom

Modified:
7 years, 10 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Make some name validation errors warnings. BUG=http://code.google.com/p/dart/issues/detail?id=8632 Committed: https://code.google.com/p/dart/source/detail?r=18783

Patch Set 2 : Make using a reserved word as a package name an error. #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -11 lines)			Patch
	M	utils/pub/validator/name.dart	View	1	2 chunks	+9 lines, -6 lines	0 comments	Download
	M	utils/tests/pub/validator_test.dart	View	1	4 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

nweiz

https://codereview.chromium.org/12313014/diff/1/utils/pub/validator/name.dart File utils/pub/validator/name.dart (right): https://codereview.chromium.org/12313014/diff/1/utils/pub/validator/name.dart#newcode76 utils/pub/validator/name.dart:76: warnings.add("$description may not be a reserved word in Dart.\n" ...

7 years, 10 months ago (2013-02-20 19:41:02 UTC) #2

Bob Nystrom

Committed patchset #2 manually as r18783 (presubmit successful).

7 years, 10 months ago (2013-02-20 21:11:56 UTC) #3

Bob Nystrom

7 years, 10 months ago (2013-02-20 21:13:40 UTC) #4

Bob Nystrom

On 2013/02/20 21:13:40, Bob Nystrom wrote: > https://codereview.chromium.org/12313014/diff/1/utils/pub/validator/name.dart > File utils/pub/validator/name.dart (right): > > https://codereview.chromium.org/12313014/diff/1/utils/pub/validator/name.dart#newcode76 ...

7 years, 10 months ago (2013-02-20 21:14:02 UTC) #5

nweiz

7 years, 10 months ago (2013-02-20 21:25:02 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/12313014/diff/1/utils/pub/validator/name.dart
File utils/pub/validator/name.dart (right):

https://codereview.chromium.org/12313014/diff/1/utils/pub/validator/name.dart...
utils/pub/validator/name.dart:76: warnings.add("$description may not be a
reserved word in Dart.\n"
On 2013/02/20 21:13:40, Bob Nystrom wrote:
> On 2013/02/20 19:41:02, nweiz wrote:
> > These should still be errors for package names.
> 
> Done.

I meant all of the newly-warning'd errors, not just this one in particular.

Expand Messages | Collapse Messages