Make some name validation errors warnings.

utils/pub/validator/name.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library name_validator;
 
 import 'dart:async';
 import 'dart:io';
 
 import '../../../pkg/path/lib/path.dart' as path;
@@ skipping 48 matching lines @@
           .where((file) => !path.split(file).contains("src") &&
                            path.extension(file) == '.dart')
           .toList();
     });
   }
 
   void _checkName(String name, String description) {
     if (name == "") {
       errors.add("$description may not be empty.");
     } else if (!new RegExp(r"^[a-zA-Z0-9_]*$").hasMatch(name)) {
-      errors.add("$description may only contain letters, numbers, and "
+      warnings.add("$description may only contain letters, numbers, and "
           "underscores.\n"
           "Using a valid Dart identifier makes the name usable in Dart code.");
     } else if (!new RegExp(r"^[a-zA-Z]").hasMatch(name)) {
-      errors.add("$description must begin with letter.\n"
+      warnings.add("$description must begin with letter.\n"
           "Using a valid Dart identifier makes the name usable in Dart code.");
     } else if (_RESERVED_WORDS.contains(name.toLowerCase())) {
-      errors.add("$description may not be a reserved word in Dart.\n"
+      warnings.add("$description may not be a reserved word in Dart.\n"

[nweiz, 2013/02/20 19:41:02]

These should still be errors for package names.

[Bob Nystrom, 2013/02/20 21:13:40]

Done.

[nweiz, 2013/02/20 21:25:02]

I meant all of the newly-warning'd errors, not just this one in particular.

           "Using a valid Dart identifier makes the name usable in Dart code.");
     } else if (new RegExp(r"[A-Z]").hasMatch(name)) {
       warnings.add('$description should be lower-case. Maybe use '
           '"${_unCamelCase(name)}"?');
     }
   }
 
   String _unCamelCase(String source) {
     var builder = new StringBuffer();
     var lastMatchEnd = 0;
     for (var match in new RegExp(r"[a-z]([A-Z])").allMatches(source)) {
       builder
         ..add(source.substring(lastMatchEnd, match.start + 1))
         ..add("_")
         ..add(match.group(1).toLowerCase());
       lastMatchEnd = match.end;
     }
     builder.add(source.substring(lastMatchEnd));
     return builder.toString().toLowerCase();
   }
 }