Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: utils/tests/pub/validator_test.dart

Issue 12313014: Make some name validation errors warnings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Make using a reserved word as a package name an error. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « utils/pub/validator/name.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/tests/pub/validator_test.dart
diff --git a/utils/tests/pub/validator_test.dart b/utils/tests/pub/validator_test.dart
index 25c5b762c55357bb96000841aada084c0aae5aa3..77d9c8652ef08bd19a26fc169f951072c3b4f1bf 100644
--- a/utils/tests/pub/validator_test.dart
+++ b/utils/tests/pub/validator_test.dart
@@ -284,12 +284,12 @@ main() {
integration('has a package name with an invalid character', () {
dir(appPath, [libPubspec("test-pkg", "1.0.0")]).scheduleCreate();
- expectValidationError(name);
+ expectValidationWarning(name);
});
integration('has a package name that begins with a number', () {
dir(appPath, [libPubspec("8ball", "1.0.0")]).scheduleCreate();
- expectValidationError(name);
+ expectValidationWarning(name);
});
integration('has a package name that contains upper-case letters', () {
@@ -307,7 +307,7 @@ main() {
libPubspec("test_pkg", "1.0.0"),
dir("lib", [file("test-pkg.dart", "int i = 0;")])
]).scheduleCreate();
- expectValidationError(name);
+ expectValidationWarning(name);
});
integration('has a library name that begins with a number', () {
@@ -315,7 +315,7 @@ main() {
libPubspec("test_pkg", "1.0.0"),
dir("lib", [file("8ball.dart", "int i = 0;")])
]).scheduleCreate();
- expectValidationError(name);
+ expectValidationWarning(name);
});
integration('has a library name that contains upper-case letters', () {
@@ -331,7 +331,7 @@ main() {
libPubspec("test_pkg", "1.0.0"),
dir("lib", [file("for.dart", "int i = 0;")])
]).scheduleCreate();
- expectValidationError(name);
+ expectValidationWarning(name);
});
integration('has a single library named differently than the package', () {
« no previous file with comments | « utils/pub/validator/name.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698