Issue 1228053002: Change stdout/stderr to binary mode on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1228053002: Change stdout/stderr to binary mode on Windows (Closed)

Created:
5 years, 5 months ago by Søren Gjesse

Modified:
5 years, 5 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Change stdout/stderr to binary mode on Windows Every other file opened in Windows is in binary mode, and there is no way of opening a file in text mode. This is a breaking change if one is relying on the CR insertion when writing to stdout/stderr on Windows. BUG=https://github.com/dart-lang/sdk/issues/19334 R=kustermann@google.com Committed: https://github.com/dart-lang/sdk/commit/4205b2997e01f2cea8e2f44c6f46ed6259ab7277

Patch Set 1 #

Patch Set 2 : Uses _O_ variants #

Patch Set 3 : Really use the _O_ version #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -7 lines)			Patch
	M	runtime/bin/file_win.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
	M	tests/standalone/io/stdio_nonblocking_test.dart	View		1 chunk	+2 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kustermann

lgtm Does this mean that running dart programs in cmd.exe might get broken output because ...

5 years, 5 months ago (2015-07-09 14:34:28 UTC) #2

Søren Gjesse

On 2015/07/09 14:34:28, kustermann wrote: > lgtm > > Does this mean that running dart ...

5 years, 5 months ago (2015-07-10 11:55:40 UTC) #3

Søren Gjesse

5 years, 5 months ago (2015-07-10 11:57:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
4205b2997e01f2cea8e2f44c6f46ed6259ab7277 (presubmit successful).

Expand Messages | Collapse Messages