runtime/bin/file_win.cc - Issue 1228053002: Change stdout/stderr to binary mode on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/file_win.cc

Issue 1228053002: Change stdout/stderr to binary mode on Windows (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Really use the _O_ version Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/file_win.cc

diff --git a/runtime/bin/file_win.cc b/runtime/bin/file_win.cc

index 8ba4a30b042f85badb420f316ed7a970273862c2..54cd64d37d5e77f466dd9c8b9bf7acf1e96df90f 100644

--- a/runtime/bin/file_win.cc

+++ b/runtime/bin/file_win.cc

@@ -196,6 +196,7 @@ File* File::OpenStdio(int fd) {

default:

UNREACHABLE();

}

+ _setmode(fd, _O_BINARY);

return new File(new FileHandle(fd));

}

« no previous file with comments | « no previous file | tests/standalone/io/stdio_nonblocking_test.dart » ('j') | no next file with comments »