Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Unified Diff: tests/standalone/io/stdio_nonblocking_test.dart

Issue 1228053002: Change stdout/stderr to binary mode on Windows (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Really use the _O_ version Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/file_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/stdio_nonblocking_test.dart
diff --git a/tests/standalone/io/stdio_nonblocking_test.dart b/tests/standalone/io/stdio_nonblocking_test.dart
index 0740dbe7267291eef258543f25a2a6e8b34d7750..05f5fde4a2a17f0e7116271692ede3fcc8c4fcf4 100644
--- a/tests/standalone/io/stdio_nonblocking_test.dart
+++ b/tests/standalone/io/stdio_nonblocking_test.dart
@@ -17,12 +17,7 @@ void main() {
print(result.stdout);
print(result.stderr);
Expect.equals(1, result.exitCode);
- if (Platform.isWindows) {
- Expect.equals('stdout\r\n\r\ntuodts\r\nABCDEFGHIJKLM\r\n', result.stdout);
- Expect.equals('stderr\r\n\r\nrredts\r\nABCDEFGHIJKLM\r\n', result.stderr);
- } else {
- Expect.equals('stdout\n\ntuodts\nABCDEFGHIJKLM\n', result.stdout);
- Expect.equals('stderr\n\nrredts\nABCDEFGHIJKLM\n', result.stderr);
- }
+ Expect.equals('stdout\n\ntuodts\nABCDEFGHIJKLM\n', result.stdout);
+ Expect.equals('stderr\n\nrredts\nABCDEFGHIJKLM\n', result.stderr);
});
}
« no previous file with comments | « runtime/bin/file_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698